implement migration to create workspace_service_account table #11943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tuliren
approved these changes
Apr 19, 2022
| final Field<String> serviceAccountId = DSL.field("service_account_id", SQLDataType.VARCHAR(31).nullable(false)); | ||
| final Field<String> serviceAccountEmail = DSL.field("service_account_email", SQLDataType.VARCHAR(256).nullable(false)); | ||
| final Field<JSONB> jsonCredential = DSL.field("json_credential", SQLDataType.JSONB.nullable(true)); | ||
| final Field<JSONB> hmacKey = DSL.field("hmac_key", SQLDataType.JSONB.nullable(true)); |
There was a problem hiding this comment.
Should both json_credential and hmac_key columns be required?
edgao
approved these changes
Apr 20, 2022
* implement persistence code for workspace_service_account table * update yaml * implement secret handling for workspace_service_account table (#11946) * implement secret handling for workspace_service_account table * add new line to the mock json * get rid of file * address review comments * update method name and add comment
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* implement migration to create workspace_service_account table * make all columns non nullable * introduce persistence code for service account table (#11944) * implement persistence code for workspace_service_account table * update yaml * implement secret handling for workspace_service_account table (#11946) * implement secret handling for workspace_service_account table * add new line to the mock json * get rid of file * address review comments * update method name and add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #11968