Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAT] Fixed schema parsing when a JSONschema was not present #11842

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

evantahler
Copy link
Contributor

What

Fixed schema parsing when a JSONschema type was not present - we now assume object if the type is not present.

🚨 User Impact 🚨

Now a previously valid test won't fail the build! This should make Airbyte developers happy.

@evantahler evantahler marked this pull request as ready for review April 8, 2022 18:57
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 amazing!

@evantahler
Copy link
Contributor Author

evantahler commented Apr 8, 2022

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2117024069
🚀 Successfully published bases/source-acceptance-test
❌ Couldn't auto-bump version for bases/source-acceptance-test

@evantahler
Copy link
Contributor Author

Note: It looks like the autobump Github Action failed, although it should not have run on this image because SAT isn't a connector. We manually confirmed that the new image is on Docker Hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants