Extract the secret's json path from a config schema #11823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o bmoric/migrate-to-secured-secret-store
|
I realized that I need some cleanup before moving it to non-draft. |
…rate-to-secured-secret-store
cgardens
reviewed
Apr 8, 2022
| * @param currentPath - The current path of the node | ||
| * @return | ||
| */ | ||
| protected Set<String> getAllSecretPathsRec(final JsonNode currentNode, final String currentPath) { |
There was a problem hiding this comment.
it feels like we're adding a 3rd jsonschema tree traversal implementation to our codebase here. that makes me nervous. i have a generic implementation that i've been working on to replace these duplicative implementations. will share this afternoon.
…s.java Co-authored-by: Topher Lubaway <asimplechris@gmail.com>
|
|
github-actions
bot
added
area/api
…o bmoric/migrate-to-secured-secret-store
…rate-to-secured-secret-store
github-actions
bot
removed
area/api
|
Close because duplicated with what Charles is doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In preparation of the migration to no store to a secret manager store, we need an easy way to list, extract and change all the secret values of a given config based on its schema .
This PR is helping to get all the secret paths. It will then use #11680 (review) to manipulate those secrets.