Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-Revert OSS branch build for Cloud workflow #11808

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

pmossman
Copy link
Contributor

@pmossman pmossman commented Apr 7, 2022

What

When #11474 was originally merged along with the Cloud PR, the stage workflow broke due to uncaught interface changes between the stage workflow and the deploy action. Both PRs were reverted to unblock staging builds. This PR addresses un-reverts the OSS PR that was reverted.

@pmossman pmossman requested a review from lmossman April 7, 2022 15:57
@pmossman pmossman requested a review from a team as a code owner April 7, 2022 15:57
@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform area/scheduler area/server area/worker Related to worker labels Apr 7, 2022
@pmossman pmossman changed the title Parker/un revert oss to cloud Un-Revert OSS branch build for Cloud workflow Apr 7, 2022
@pmossman pmossman temporarily deployed to more-secrets April 7, 2022 18:35 Inactive
@pmossman pmossman temporarily deployed to more-secrets April 7, 2022 18:35 Inactive
@pmossman pmossman force-pushed the parker/un-revert-oss-to-cloud branch from 9069a7e to a3439ad Compare April 7, 2022 18:59
@pmossman pmossman temporarily deployed to more-secrets April 7, 2022 19:01 Inactive
@pmossman pmossman temporarily deployed to more-secrets April 7, 2022 19:01 Inactive
@pmossman pmossman force-pushed the parker/un-revert-oss-to-cloud branch from a3439ad to 1695642 Compare April 8, 2022 16:28
@pmossman pmossman temporarily deployed to more-secrets April 8, 2022 16:30 Inactive
@pmossman pmossman temporarily deployed to more-secrets April 8, 2022 16:30 Inactive
@pmossman pmossman temporarily deployed to more-secrets April 8, 2022 18:35 Inactive
@pmossman pmossman temporarily deployed to more-secrets April 8, 2022 18:35 Inactive
@pmossman pmossman temporarily deployed to more-secrets April 8, 2022 18:45 Inactive
@pmossman pmossman temporarily deployed to more-secrets April 8, 2022 18:45 Inactive
Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not giving this a close review, since this is unchanged from the earlier approved PR that was reverted

@pmossman pmossman temporarily deployed to more-secrets April 8, 2022 20:19 Inactive
@pmossman pmossman temporarily deployed to more-secrets April 8, 2022 20:19 Inactive
@pmossman pmossman force-pushed the parker/un-revert-oss-to-cloud branch from 1695642 to 88018c2 Compare April 8, 2022 21:49
@pmossman pmossman temporarily deployed to more-secrets April 8, 2022 21:51 Inactive
@pmossman pmossman temporarily deployed to more-secrets April 8, 2022 21:51 Inactive
@pmossman pmossman merged commit 884a94e into master Apr 8, 2022
@pmossman pmossman deleted the parker/un-revert-oss-to-cloud branch April 8, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation area/platform issues related to the platform area/scheduler area/server area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants