Added useSuspenseQuery hook, remove top-level suspense: true #11746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/frontend
area/platform
krishnaglick
commented
Apr 6, 2022
| @@ -27,6 +27,5 @@ export const useDocumentation = (documentationUrl: string): UseDocumentationResu | |||
| refetchOnMount: false, | |||
| refetchOnWindowFocus: false, | |||
| retry: false, | |||
| suspense: false, | |||
There was a problem hiding this comment.
Suspense defaults to false now
| @@ -42,7 +39,6 @@ export const useGetDestinationDefinitionSpecificationAsync = ( | |||
|
|
|||
| const escapedId = id ?? ""; | |||
| return useQuery(destinationDefinitionSpecificationKeys.detail(escapedId), () => service.get(escapedId), { | |||
| suspense: false, | |||
There was a problem hiding this comment.
Suspense defaults to false now
| @@ -42,7 +39,6 @@ export const useGetSourceDefinitionSpecificationAsync = ( | |||
|
|
|||
| const escapedId = id ?? ""; | |||
| return useQuery(sourceDefinitionSpecificationKeys.detail(escapedId), () => service.get(escapedId), { | |||
| suspense: false, | |||
There was a problem hiding this comment.
Suspense defaults to false now
| ) { | ||
| return useQuery<TQueryFnData, TError, TData, TQueryKey>(queryKey, queryFn, { | ||
| ...options, | ||
| suspense: true, |
There was a problem hiding this comment.
Force suspense for the hook
| return useQuery<TQueryFnData, TError, TData, TQueryKey>(queryKey, queryFn, { | ||
| ...options, | ||
| suspense: true, | ||
| }).data as typeof options extends Disabled ? TData | undefined : TData; |
There was a problem hiding this comment.
We sometimes disable the call due to the rule of hooks. This lets typescript correctly infer the return type.
| @@ -5,7 +5,6 @@ import { ReactQueryDevtools } from "react-query/devtools"; | |||
| const queryClient = new QueryClient({ | |||
| defaultOptions: { | |||
| queries: { | |||
| suspense: true, | |||
There was a problem hiding this comment.
Defaults to false now since we have the new suspense hook.
timroes
approved these changes
Apr 6, 2022
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removed the top-level Suspense configuration in favor of a useSuspenseQuery hook, swapping-in-place where appropriate.
No need for
as QueryObserverSuccessResult<T>).dataany more.