🐙 octavia-cli: create octavia env file during install #11005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosmarxm
reviewed
Mar 10, 2022
| @@ -4,6 +4,7 @@ | |||
| # It creates an octavia alias in your profile bound to a docker run command | |||
|
|
|||
| VERSION=dev | |||
| OCTAVIA_ENV_FILE=${HOME}/.octavia | |||
There was a problem hiding this comment.
This makes more complex to complex to work using Github Actions (maybe?)
There was a problem hiding this comment.
IMO GitHub actions users should not use the docker run command directly and not use the alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a env file (
~/.octavia) to allow usesr to map whatever env var they want tooctaviacontainer.This allows them to set secret values directly in this file.
Path to this file is stored in the bash profile of the user and can be changed by changing the value of their
OCTAVIA_ENV_FILEenv var.