Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct cancelled job metric name. #10658

Merged
merged 10 commits into from
Feb 25, 2022
Merged

Correct cancelled job metric name. #10658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
36549cd
Checkpoint: Get create job metric working.
davinchia Feb 24, 2022
c4102ef
Add tags class.
davinchia Feb 24, 2022
ed433fa
Add tests.
davinchia Feb 24, 2022
801ab3f
Add tests for jobIdToReleaseStages function and simplify SQL.
davinchia Feb 24, 2022
80e1a00
Inject all metrics.
davinchia Feb 24, 2022
8732204
Respond to PR feedback.
davinchia Feb 25, 2022
d636cc0
More method refactoring.
davinchia Feb 25, 2022
83de723
Merge remote-tracking branch 'origin' into davinchia/cloud-dashboard-1
davinchia Feb 25, 2022
8b8d245
Fix wrong tag and metric name.
davinchia Feb 25, 2022
476ad87
Merge remote-tracking branch 'origin' into davinchia/cloud-dashboard-2
davinchia Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions airbyte-metrics/lib/src/main/java/io/airbyte/metrics/lib/MetricTags.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,14 @@
*/
public class MetricTags {

private static final String RELEASE_STAGE = "release_stage:";
private static final String RELEASE_STAGE = "release_stage";

public static String getReleaseStage(final ReleaseStage stage) {
return RELEASE_STAGE + ":" + stage.getLiteral();
return tagDelimit(RELEASE_STAGE, stage.getLiteral());
}

private static String tagDelimit(final String tagName, final String tagVal) {
return String.join(":", tagName, tagVal);
}

}
2 changes: 1 addition & 1 deletion ...irbyte/workers/temporal/scheduling/activities/JobCreationAndStatusUpdateActivityImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public void jobCancelled(final JobCancelledInput input) {

final Job job = jobPersistence.getJob(jobId);
trackCompletion(job, JobStatus.FAILED);
emitJobIdToReleaseStagesMetric(MetricsRegistry.JOB_SUCCEEDED_BY_RELEASE_STAGE, jobId);
emitJobIdToReleaseStagesMetric(MetricsRegistry.JOB_CANCELLED_BY_RELEASE_STAGE, jobId);
jobNotifier.failJob("Job was cancelled", job);
} catch (final IOException e) {
throw new RetryableException(e);
Expand Down