Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source Facebook Marketing: have at least 90% unit test coverage #10545

Merged

Conversation

lazebnyi
Copy link
Collaborator

What

#10453 - Source Facebook Marketing: have at least 90% unit test coverage

How

Increased unit test coverage to 90%

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 22, 2022
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 15:32 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 15:32 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 15:35 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 15:35 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Feb 22, 2022

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1882504375
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1882504375
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              27      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/api.py                               95     12    87%
source_facebook_marketing/streams/base_streams.py             133     30    77%
source_facebook_marketing/streams/streams.py                   75     19    75%
source_facebook_marketing/streams/common.py                    38     11    71%
source_facebook_marketing/source.py                            38     16    58%
source_facebook_marketing/streams/base_insight_streams.py     125     59    53%
source_facebook_marketing/streams/async_job.py                204    128    37%
source_facebook_marketing/streams/async_job_manager.py         74     56    24%
-------------------------------------------------------------------------------
TOTAL                                                         813    331    59%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/async_job.py                204      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              27      0   100%
source_facebook_marketing/source.py                            38      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/common.py                    38      1    97%
source_facebook_marketing/streams/async_job_manager.py         74      3    96%
source_facebook_marketing/streams/base_insight_streams.py     125     11    91%
source_facebook_marketing/streams/streams.py                   75     10    87%
source_facebook_marketing/api.py                               95     16    83%
source_facebook_marketing/streams/base_streams.py             133     39    71%
-------------------------------------------------------------------------------
TOTAL                                                         813     80    90%

@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 15:41 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 15:42 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 22, 2022 15:43 Inactive
@lazebnyi lazebnyi linked an issue Feb 22, 2022 that may be closed by this pull request
@github-actions github-actions bot removed the area/documentation Improvements or additions to documentation label Feb 22, 2022
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 16:03 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 16:03 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
@lazebnyi , please merge your changes without publishing

@lazebnyi lazebnyi marked this pull request as ready for review February 22, 2022 16:30
@lazebnyi lazebnyi merged commit 2b927b0 into master Feb 22, 2022
@lazebnyi lazebnyi deleted the lazebnyi/10453-facebook-marketing-improve-coverage-to-90 branch February 22, 2022 16:30
@lazebnyi lazebnyi removed the request for review from annalvova05 February 22, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Facebook Marketing: increase unit test coverage at least 90%
3 participants