Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions to checkout the correct tag #1051

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

cgardens
Copy link
Contributor

@cgardens cgardens commented Nov 22, 2020

What

  • docker-compose up leads to a broken state right now.
  • issue described here: Document Release Story #1049
  • versions of connectors have been updates. but docker-compose up runs whatever the core containers were when the last release happened. the issue is that the new connector versions aren't compatible with those old version anymore (catalog updates and secrets changes).

How

  • this is a stop gap until we decide how we want to resolve the issue mentioned above. this is enough to get us to a non-broken state. The alternative can be found in this draft pr: revert connectors in index back to what they were at release time #1050, but i think it is a worse hack to get this fixed. I am going to merge this as soon as the build passes as a hotfix.

@cgardens cgardens merged commit 77c2070 into master Nov 22, 2020
@cgardens cgardens deleted the cgardens/update_start_up_instructions branch November 22, 2020 03:55
cgardens added a commit that referenced this pull request Nov 22, 2020
cgardens added a commit that referenced this pull request Nov 22, 2020
@@ -15,6 +15,8 @@ First of all, make sure you have Docker and Docker Compose installed. Then run t
```text
git clone https://github.com/airbytehq/airbyte.git
cd airbyte
git fetch --tags
git checkout tags/v0.5.1-alpha
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we do

git checkout tags/$(cat .env | grep VERSION | cut -d = -f 2)

@michel-tricot
Copy link
Contributor

I am a bit surprised by the need for that change.

I thought we didn't rely on the state of the repo when doing a docker compose up. It should only use published images doesn't it?

@cgardens
Copy link
Contributor Author

I reverted this. This was wrong; I was temporarily confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants