Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject check connection resource #10410

Merged
merged 5 commits into from
Feb 18, 2022
Merged

Inject check connection resource #10410

merged 5 commits into from
Feb 18, 2022
+185 −63

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented Feb 17, 2022 •
edited
Loading

What

Make it possible to set resource limits specifically for Check Connection. This helps speed up the Check Connection operation.

After this PR is merged, I will do an OSS release and make the required Helm changes in Cloud.

How

  • Add env vars for cpu request, cpu limit, memory request and memory limit for Check Connection. This variables will default to the job main resource configs if unset.
  • Edited the check connection worker configs to look at the check connection env vars.

Recommended reading order

  1. Configs.java and EnvConfigs.Java for implementation.
  2. EnvConfigsTest.java for tests
  3. WorkerConfigs.java for use of new env vars

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Sorry, something went wrong.

@davinchia davinchia mentioned this pull request Feb 17, 2022
Closed
3 tasks
@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Feb 17, 2022
@davinchia davinchia temporarily deployed to more-secrets February 17, 2022 18:05 Inactive
@davinchia davinchia temporarily deployed to more-secrets February 17, 2022 18:05 Inactive
davinchia
davinchia commented Feb 17, 2022
View reviewed changes
airbyte-config/models/src/test/java/io/airbyte/config/EnvConfigsTest.java
@@ -26,237 +29,307 @@ void setUp() {

@Test
void ensureGetEnvBehavior() {
Assertions.assertNull(System.getenv("MY_RANDOM_VAR_1234"));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converted into a static import so the code is slightly easier to read

@davinchia davinchia marked this pull request as ready for review February 17, 2022 18:11
pmossman
pmossman approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@pmossman pmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

cgardens
cgardens approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so java connectors can be snappier?

@davinchia
Copy link
Contributor Author

Yes!

@davinchia davinchia merged commit ef673c5 into master Feb 18, 2022
@davinchia davinchia deleted the davinchia/inject-check-connection-resource branch February 18, 2022 08:06
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmossman pmossman

@cgardens cgardens

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davinchia @pmossman @cgardens