Show warning for Alpha and Beta connectors #10319
Merged
+52
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/frontend
area/platform
jrhizor
reviewed
Feb 14, 2022
|
Sorry, I should have called it out in the issue, but from the comment https://www.figma.com/file/etaOkOsnXMoKwbfhCD71kw?node-id=30010:138107#144935197 we're looking at only having the inline warning, not the modal. |
timroes
reviewed
Feb 17, 2022
timroes
reviewed
Feb 17, 2022
airbyte-webapp/src/views/Connector/ServiceForm/components/WarningMessage.tsx
Outdated
Show resolved
Hide resolved
juliachvyrova
changed the title
juliachvyrova
force-pushed
the
julia/acknowledgement-of-terms-modal
branch
from
b8dd6dc to
2d4ea01
Compare
juliachvyrova
force-pushed
the
julia/acknowledgement-of-terms-modal
branch
from
2d4ea01 to
f3e9f2b
Compare
timroes
reviewed
Feb 17, 2022
| @@ -35,7 +35,7 @@ const AdditionMessage = styled.span` | |||
| `; | |||
|
|
|||
| const LabeledToggle: React.FC<IProps> = (props) => ( | |||
| <ToggleContainer> | |||
| <ToggleContainer className={props.className}> | |||
There was a problem hiding this comment.
❓ Is this a left over, or something that is fixing something?
timroes
changed the title
timroes
suggested changes
Feb 17, 2022
airbyte-webapp/src/views/Connector/ServiceForm/components/WarningMessage.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/views/Connector/ServiceForm/components/WarningMessage.tsx
Outdated
Show resolved
Hide resolved
jrhizor
approved these changes
Feb 17, 2022
timroes
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add warning message in Source/Destination form for
alphaandbetaconnectorsCloses #9712