Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT: Introduce new way to compare records based on PK #9718

Closed
keu opened this issue Jan 23, 2022 · 0 comments · Fixed by #9768
Closed

SAT: Introduce new way to compare records based on PK #9718

keu opened this issue Jan 23, 2022 · 0 comments · Fixed by #9768
Assignees
Labels

Comments

@keu
Copy link
Contributor

keu commented Jan 23, 2022

Tell us about the problem you're trying to solve

Incremental and full refresh tests currently assume that records remain unchanged in streams during the test. This is false in many cases and is not what we should test. Instead, SAT should use PKs and compare records only based on PKs when it is possible.

Describe the solution you’d like

At least full refresh test should compare records using PKs. In case PKs are not defined in the catalog the test should use the old algorithm.

Describe the alternative you’ve considered or used

Fix SAT tests forever.

@keu keu self-assigned this Jan 23, 2022
@keu keu linked a pull request Jan 24, 2022 that will close this issue
@keu keu removed the needs-triage label Jan 24, 2022
@keu keu closed this as completed in #9768 Jan 27, 2022
keu added a commit that referenced this issue Jan 27, 2022
* fix asserts

Co-authored-by: Eugene Kulak <kulak.eugene@gmail.com>
@keu keu added this to the Connectors Jan 28 2022 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant