-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit required-reviewer-checks and CODEOWNERS #37662
Comments
|
Kat uses this workflow! I will remove extensibility from the lists and see how we fare. I will also ask GL for their preference. |
## What <!-- * Describe what the change is solving. Link all GitHub issues related to this change. --> * Reduce PR noise of automatic review requesting on things that we don't actually review. * Close #37662 Notes: * Kat still wants the breaking change reviewer tags * investigating what API sources wants out of this autotagger [separately](https://airbytehq-team.slack.com/archives/C02U9R3AF37/p1714499322978079) and will follow up in a separate PR based on that ## How <!-- * Describe how code changes achieve the solution. --> * Remove these checks. This made more sense conceptually for code and testing than having empty sets, becuase we would still output an empty requirements file. instead of hacking that apart, I think this makes more sense, but am open to other ideas ## Can this PR be safely reverted and rolled back? <!-- * If unsure, leave it blank. --> - [x] YES 💚 - [ ] NO ❌
Problem
I feel like the extensibility team gets auto-tagged in too many PRs for review for it to be useful. I'd like to audit it to narrow it down to scopes we'd actually like to review/at least be informed about, to reduce the notification fatigue.
As exhibit A, see my PR filters, the first of which is for "the extensibility team's review is requested, but someone on my team made the pr", and the second is for "the extensibility team's review is requested". Emphasis on the 98 PRs in the latter category (to be fair, its a little egregious at the moment because of BL's PRs, but still)
Current State
The state of required-reviewer-checks:
Do we still want to review
strategic python connector changes is being triggered for non-python changes, e.g. here
CODEOWNERS airbyte:

CODEOWNERS airbyte-platform:

The text was updated successfully, but these errors were encountered: