Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit required-reviewer-checks and CODEOWNERS #37662

Closed
erohmensing opened this issue Apr 29, 2024 · 2 comments · Fixed by #37716
Closed

Audit required-reviewer-checks and CODEOWNERS #37662

erohmensing opened this issue Apr 29, 2024 · 2 comments · Fixed by #37716
Assignees

Comments

@erohmensing
Copy link
Contributor

erohmensing commented Apr 29, 2024

Problem

I feel like the extensibility team gets auto-tagged in too many PRs for review for it to be useful. I'd like to audit it to narrow it down to scopes we'd actually like to review/at least be informed about, to reduce the notification fatigue.

As exhibit A, see my PR filters, the first of which is for "the extensibility team's review is requested, but someone on my team made the pr", and the second is for "the extensibility team's review is requested". Emphasis on the 98 PRs in the latter category (to be fair, its a little egregious at the moment because of BL's PRs, but still)

image.png

Current State

The state of required-reviewer-checks:

image.png

  • Do we still want to review

    • backwards compatibility changes?
    • Test strictness level chnages?
    • Strategic python connector changes?
  • strategic python connector changes is being triggered for non-python changes, e.g. here

CODEOWNERS airbyte:
image.png

  • do we want to be tagged in all things CI?

CODEOWNERS airbyte-platform:
image.png

image.png

@erohmensing
Copy link
Contributor Author

erohmensing commented Apr 30, 2024

  • Do we still review backwards compatibility, bypass reasons, and test strictness level?

  • can we remove this entire review requirements module and just go on codeowners?

    • check with kat about breaking change reviewers
  • .github: has airbyte ci action and a lot of workflows that we are in charge of. if this is too noisy, we could consider making a smaller group of CI people who want to be notified

  • if kat is not using it, diable the workflow in the UI (see if this stops it from appearing)

  • is kat is using it, make the required reviewers list empty for non-breaking change checks

@erohmensing erohmensing self-assigned this Apr 30, 2024
@erohmensing
Copy link
Contributor Author

Kat uses this workflow! I will remove extensibility from the lists and see how we fare. I will also ask GL for their preference.

erohmensing added a commit that referenced this issue May 1, 2024
## What
<!--
* Describe what the change is solving. Link all GitHub issues related to this change.
-->
* Reduce PR noise of automatic review requesting on things that we don't actually review. 
* Close #37662

Notes:
* Kat still wants the breaking change reviewer tags
* investigating what API sources wants out of this autotagger [separately](https://airbytehq-team.slack.com/archives/C02U9R3AF37/p1714499322978079) and will follow up in a separate PR based on that 

## How
<!--
* Describe how code changes achieve the solution.
-->
* Remove these checks. This made more sense conceptually for code and testing than having empty sets, becuase we would still output an empty requirements file. instead of hacking that apart, I think this makes more sense, but am open to other ideas


## Can this PR be safely reverted and rolled back?
<!--
* If unsure, leave it blank.
-->
- [x] YES 💚
- [ ] NO ❌
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant