Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date format should be explicit in placeholder #264

Closed
johnlafleur opened this issue Sep 14, 2020 · 1 comment · Fixed by #295
Closed

Date format should be explicit in placeholder #264

johnlafleur opened this issue Sep 14, 2020 · 1 comment · Fixed by #295
Assignees
Labels
type/enhancement New feature or request

Comments

@johnlafleur
Copy link
Contributor

johnlafleur commented Sep 14, 2020

Expected Behavior

When adding Postgres source, a field is asking for start_date, and apparently, we need the format YYYY-MM-DD, otherwise it won't work. We need to make it explicit in the placeholder, such as in the screenshot.

Another solution is to put the format as a description, what do you think @cgardens ?

Screen Shot 2020-09-15 at 10 12 59 AM

Current Behavior

There is no info about which format is expected for the date.

@cgardens
Copy link
Contributor

cgardens commented Sep 14, 2020

@jamakase for this let's take a similar approach as with the descriptions. We will populate the examples field on the field there is an example we want to show. According to the jsonschema spec it looks like examples is expected to be an array of strings. you can assume that the first element in the array, if it exists is the one we want to display. Does that work?

@jamakase jamakase linked a pull request Sep 15, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants