Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields not centered vertically in Summary cell within source detail page #263

Closed
johnlafleur opened this issue Sep 14, 2020 · 0 comments · Fixed by #295
Closed

Fields not centered vertically in Summary cell within source detail page #263

johnlafleur opened this issue Sep 14, 2020 · 0 comments · Fixed by #295
Assignees
@jamakase
Labels
type/bug Something isn't working

Comments

@johnlafleur
Copy link
Contributor

johnlafleur commented Sep 14, 2020 •
edited
Loading

In the summary cell at the top of the sources detail page, in Overview tab, the items are not centered vertically, which doesn't look beautiful. See screenshot.

ENABLED and toggle should be moved down 4px.
The rest should be moved down 7px.

Screen Shot 2020-09-15 at 9 32 12 AM
@johnlafleur johnlafleur added type/bug Something isn't working area/frontend labels Sep 14, 2020
@jamakase jamakase linked a pull request Sep 15, 2020 that will close this issue
Ui fixes #295
Merged
davydov-d added a commit that referenced this issue Jun 9, 2022
@davydov-d
#263 oncall: bump google ads version 15.1.1, protobuf 3.20.0
e9cf5e8
evantahler added a commit that referenced this issue Jun 9, 2022
@evantahler @davydov-d @octavia-squidington-iii
Fix source-google-ads on M1 Macs by pinning protobuf==3.14 (#13624)
db67936 
* Bump `source-google-ads` to build for both AMD and ARM

* pin protobuf==3.14

* update readme

* #263 oncall: bump google ads version 15.1.1, protobuf 3.20.0

* auto-bump connector version

Co-authored-by: Denys Davydov <davydov.den18@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamakase jamakase

Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ui fixes airbytehq/airbyte
2 participants
@jamakase @johnlafleur