Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate sensitive spec fields #1001

Closed
sherifnada opened this issue Nov 17, 2020 · 1 comment · Fixed by #1012
Closed

Annotate sensitive spec fields #1001

sherifnada opened this issue Nov 17, 2020 · 1 comment · Fixed by #1012
Labels
type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

Sub-issue of #986

Acceptance Criteria

  • All sensitive fields in all connector specs have sensitive: true annotation set
@michel-tricot
Copy link
Contributor

michel-tricot commented Nov 17, 2020 •
edited
Loading

we should prefix this custom annotation with airbyte : airbyteSensitive: true just to limit the risk of a collision

@sherifnada sherifnada mentioned this issue Nov 18, 2020
Merged
1 task
bazarnov added a commit that referenced this issue Jan 17, 2023
@bazarnov
updated expected records #1001
7f4f9f9
bazarnov added a commit that referenced this issue Jan 17, 2023
@bazarnov
updated expected records #1001
eaf7747
bazarnov added a commit that referenced this issue Jan 18, 2023
@bazarnov
updated expected records #1001
11dbf4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

annotate secret fields airbytehq/airbyte
2 participants
@michel-tricot @sherifnada