Skip to content

Commit

Permalink
formated
Browse files Browse the repository at this point in the history
  • Loading branch information
@bazarnov
bazarnov committed Feb 2, 2022
1 parent 27b9d1c commit ea054bd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion airbyte-oauth/src/main/java/io/airbyte/oauth/flows/GithubOAuthFlow.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ protected String formatConsentUrl(final UUID definitionId,
.addParameter("client_id", clientId)
.addParameter("redirect_uri", redirectUrl)
// we add `scopes` and `state` after we've already built the url, to prevent url encoding for scopes
// see https://docs.github.com/en/developers/apps/building-oauth-apps/scopes-for-oauth-apps#available-scopes
// https://docs.github.com/en/developers/apps/building-oauth-apps/scopes-for-oauth-apps#available-scopes
// we need to keep scopes in the format of: < scope1%20scope2:sub_scope%20scope3 >
.build().toString() + "&scope=" + getScopes() + "&state=" + getState();
} catch (final URISyntaxException e) {
Expand Down

1 comment on commit ea054bd

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube Report

SonarQube report for Airbyte Connectors Source Github(#9868)

Measures

Name Value Name Value Name Value
Vulnerabilities 0 Duplicated Lines (%) 0.0 Lines to Cover 623
Coverage 40.6 Duplicated Blocks 0 Reliability Rating A
Lines of Code 839 Quality Gate Status OK Code Smells 13
Bugs 0 Security Rating A Blocker Issues 0
Critical Issues 3 Major Issues 5 Minor Issues 5

Detected Issues

Rule File Description Message
python:S3776 (CRITICAL) source_github/streams.py:83 Cognitive Complexity of functions should not be too high Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed.
python:isort_need_format (MINOR) unit_tests/test_stream.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
flake8:E501 (MAJOR) source_github/streams.py:66 line too long (82 > 79 characters) line too long (150 > 140 characters)
python:S5886 (MAJOR) source_github/streams.py:76 Function return types should be consistent with their type hint Return a value of type "Union[int, float]" instead of "NoneType" or update function "backoff_time" type hint.
python:S2638 (CRITICAL) source_github/streams.py:735 Method overrides should not change contracts Add missing parameters organization.
python:isort_need_format (MINOR) unit_tests/test_source.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
python:isort_need_format (MINOR) unit_tests/unit_test.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
python:isort_need_format (MINOR) main.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
python:mypy_unknown (MINOR) main.py Unknown error Duplicate module named "main" (also at "./fixtures/main.py")
flake8:E501 (MAJOR) fixtures/github.py:22 line too long (82 > 79 characters) line too long (151 > 140 characters)
python:S5797 (CRITICAL) fixtures/github.py:79 Constants should not be used as conditions Replace this expression; used as a condition it will always be constant.
python:S112 (MAJOR) source_github/source.py:69 "Exception" and "BaseException" should not be raised Replace this generic exception class with a more specific one.
flake8:C901 (MAJOR) source_github/streams.py:83 flake8:C901 'GithubStream.read_records' is too complex (14)

Coverage (40.6%)

File Coverage File Coverage
fixtures/github.py 0.0 fixtures/main.py 0.0
integration_tests/acceptance.py 0.0 main.py 0.0
setup.py 0.0 source_github/init.py 100.0
source_github/source.py 55.1 source_github/streams.py 55.9
unit_tests/test_source.py 0.0 unit_tests/test_stream.py 0.0
unit_tests/unit_test.py 0.0

Please sign in to comment.