Update fields in source-connectors specifications: google-ads (#9149)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com> Co-authored-by: Serhii Chvaliuk <grubberr@gmail.com>
airbytehq · Jan 19, 2022 · a1e2b63 · a1e2b63
1 parent cb8644e
commit a1e2b63
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 33 deletions.
diff --git a/...ain/resources/config/STANDARD_SOURCE_DEFINITION/253487c0-2246-43ba-a21f-5116b20a2c50.json b/...ain/resources/config/STANDARD_SOURCE_DEFINITION/253487c0-2246-43ba-a21f-5116b20a2c50.json
@@ -2,7 +2,7 @@
   "sourceDefinitionId": "253487c0-2246-43ba-a21f-5116b20a2c50",
   "name": "Google Ads",
   "dockerRepository": "airbyte/source-google-ads",
-  "dockerImageTag": "0.1.20",
+  "dockerImageTag": "0.1.21",
   "documentationUrl": "https://docs.airbyte.io/integrations/sources/google-ads",
   "icon": "google-adwords.svg"
 }
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -238,7 +238,7 @@
 - name: Google Ads
   sourceDefinitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
   dockerRepository: airbyte/source-google-ads
-  dockerImageTag: 0.1.20
+  dockerImageTag: 0.1.21
   documentationUrl: https://docs.airbyte.io/integrations/sources/google-ads
   icon: google-adwords.svg
   sourceType: api

diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml
@@ -2151,9 +2151,9 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-google-ads:0.1.20"
+- dockerImage: "airbyte/source-google-ads:0.1.21"
   spec:
-    documentationUrl: "https://docs.airbyte.io/integrations/sources/google-ads"
+    documentationUrl: "https://docs.airbyte.com/integrations/sources/google-ads"
     connectionSpecification:
       $schema: "http://json-schema.org/draft-07/schema#"
       title: "Google Ads Spec"
@@ -2178,44 +2178,42 @@
               type: "string"
               title: "Developer Token"
               description: "Developer token granted by Google to use their APIs. More\
-                \ instruction on how to find this value in our <a href=\"https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\"\
+                \ instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\"\
                 >docs</a>"
               airbyte_secret: true
             client_id:
               type: "string"
-              title: "Client Id"
-              description: "Google client id. More instruction on how to find this\
-                \ value in our <a href=\"https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\"\
+              title: "Client ID"
+              description: "The Client ID of your Google Ads developer application.\
+                \ More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\"\
                 >docs</a>"
             client_secret:
               type: "string"
               title: "Client Secret"
-              description: "Google client secret. More instruction on how to find\
-                \ this value in our <a href=\"https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\"\
+              description: "The Client Secret of your Google Ads developer application.\
+                \ More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\"\
                 >docs</a>"
               airbyte_secret: true
             access_token:
               type: "string"
               title: "Access Token"
-              description: "Access token generated using developer_token, oauth_client_id,\
-                \ and oauth_client_secret. More instruction on how to find this value\
-                \ in our <a href=\"https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\"\
+              description: "Access Token for making authenticated requests. More instruction\
+                \ on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\"\
                 >docs</a>"
               airbyte_secret: true
             refresh_token:
               type: "string"
               title: "Refresh Token"
-              description: "Refresh token generated using developer_token, oauth_client_id,\
-                \ and oauth_client_secret. More instruction on how to find this value\
-                \ in our <a href=\"https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\"\
+              description: "The token for obtaining a new access token. More instruction\
+                \ on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\"\
                 >docs</a>"
               airbyte_secret: true
         customer_id:
           title: "Customer ID"
           type: "string"
-          description: "Customer id must be specified as a 10-digit number without\
+          description: "Customer ID must be specified as a 10-digit number without\
             \ dashes. More instruction on how to find this value in our <a href=\"\
-            https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\"\
+            https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\"\
             >docs</a>. Metrics streams like AdGroupAdReport cannot be requested for\
             \ a manager account."
           order: 1
@@ -2237,7 +2235,7 @@
             properties:
               query:
                 type: "string"
-                title: "Custom query"
+                title: "Custom Query"
                 description: "A custom defined GAQL query for building the report.\
                   \ Should not contain segments.date expression as it used by incremental\
                   \ streams"
@@ -2246,7 +2244,7 @@
                   \ FROM campaign WHERE campaign.status = 'PAUSED'"
               table_name:
                 type: "string"
-                title: "Destination table name"
+                title: "Destination Table Name"
                 description: "The table name in your destination database for choosen\
                   \ query."
         login_customer_id:
@@ -2261,7 +2259,9 @@
         conversion_window_days:
           title: "Conversion Window (Optional)"
           type: "integer"
-          description: "Define the historical replication lookback window in days"
+          description: "A conversion window is the period of time after an ad interaction\
+            \ (such as an ad click or video view) during which a conversion, such\
+            \ as a purchase, is recorded in Google Ads."
           minimum: 0
           maximum: 1095
           default: 14

diff --git a/airbyte-integrations/connectors/source-google-ads/Dockerfile b/airbyte-integrations/connectors/source-google-ads/Dockerfile
@@ -13,5 +13,5 @@ RUN pip install .
 
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.20
+LABEL io.airbyte.version=0.1.21
 LABEL io.airbyte.name=airbyte/source-google-ads
diff --git a/airbyte-integrations/connectors/source-google-ads/source_google_ads/spec.json b/airbyte-integrations/connectors/source-google-ads/source_google_ads/spec.json
@@ -1,5 +1,5 @@
 {
-  "documentationUrl": "https://docs.airbyte.io/integrations/sources/google-ads",
+  "documentationUrl": "https://docs.airbyte.com/integrations/sources/google-ads",
   "connectionSpecification": {
     "$schema": "http://json-schema.org/draft-07/schema#",
     "title": "Google Ads Spec",
@@ -21,38 +21,38 @@
           "developer_token": {
             "type": "string",
             "title": "Developer Token",
-            "description": "Developer token granted by Google to use their APIs. More instruction on how to find this value in our <a href=\"https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\">docs</a>",
+            "description": "Developer token granted by Google to use their APIs. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>",
             "airbyte_secret": true
           },
           "client_id": {
             "type": "string",
-            "title": "Client Id",
-            "description": "Google client id. More instruction on how to find this value in our <a href=\"https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\">docs</a>"
+            "title": "Client ID",
+            "description": "The Client ID of your Google Ads developer application. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>"
           },
           "client_secret": {
             "type": "string",
             "title": "Client Secret",
-            "description": "Google client secret. More instruction on how to find this value in our <a href=\"https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\">docs</a>",
+            "description": "The Client Secret of your Google Ads developer application. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>",
             "airbyte_secret": true
           },
           "access_token": {
             "type": "string",
             "title": "Access Token",
-            "description": "Access token generated using developer_token, oauth_client_id, and oauth_client_secret. More instruction on how to find this value in our <a href=\"https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\">docs</a>",
+            "description": "Access Token for making authenticated requests. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>",
             "airbyte_secret": true
           },
           "refresh_token": {
             "type": "string",
             "title": "Refresh Token",
-            "description": "Refresh token generated using developer_token, oauth_client_id, and oauth_client_secret. More instruction on how to find this value in our <a href=\"https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\">docs</a>",
+            "description": "The token for obtaining a new access token. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>",
             "airbyte_secret": true
           }
         }
       },
       "customer_id": {
         "title": "Customer ID",
         "type": "string",
-        "description": "Customer id must be specified as a 10-digit number without dashes. More instruction on how to find this value in our <a href=\"https://docs.airbyte.io/integrations/sources/google-adwords#setup-guide\">docs</a>. Metrics streams like AdGroupAdReport cannot be requested for a manager account.",
+        "description": "Customer ID must be specified as a 10-digit number without dashes. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>. Metrics streams like AdGroupAdReport cannot be requested for a manager account.",
         "order": 1
       },
       "start_date": {
@@ -72,15 +72,15 @@
           "properties": {
             "query": {
               "type": "string",
-              "title": "Custom query",
+              "title": "Custom Query",
               "description": "A custom defined GAQL query for building the report. Should not contain segments.date expression as it used by incremental streams",
               "examples": [
                 "SELECT segments.ad_destination_type, campaign.advertising_channel_sub_type FROM campaign WHERE campaign.status = 'PAUSED'"
               ]
             },
             "table_name": {
               "type": "string",
-              "title": "Destination table name",
+              "title": "Destination Table Name",
               "description": "The table name in your destination database for choosen query."
             }
           }
@@ -95,7 +95,7 @@
       "conversion_window_days": {
         "title": "Conversion Window (Optional)",
         "type": "integer",
-        "description": "Define the historical replication lookback window in days",
+        "description": "A conversion window is the period of time after an ad interaction (such as an ad click or video view) during which a conversion, such as a purchase, is recorded in Google Ads.",
         "minimum": 0,
         "maximum": 1095,
         "default": 14,

diff --git a/docs/integrations/sources/google-ads.md b/docs/integrations/sources/google-ads.md
@@ -102,6 +102,7 @@ This source is constrained by whatever API limits are set for the Google Ads tha
 
 | Version | Date | Pull Request | Subject |
 | :--- | :--- | :--- | :--- |
+| `0.1.21` | 2021-12-28 | [9149](https://github.com/airbytehq/airbyte/pull/9149) | Update title and description |
 | `0.1.20` | 2021-12-22 | [9071](https://github.com/airbytehq/airbyte/pull/9071) | Fix: Keyword schema enum |
 | `0.1.19` | 2021-12-14 | [8431](https://github.com/airbytehq/airbyte/pull/8431) | Add new streams: Geographic and Keyword |
 | `0.1.18` | 2021-12-09 | [8225](https://github.com/airbytehq/airbyte/pull/8225) | Include time_zone to sync. Remove streams for manager account. |