Skip to content

Commit

Permalink
pass USE_STREAM_CAPABLE_STATE env var to containers/deployments (#14737)
Browse files Browse the repository at this point in the history
  • Loading branch information
lmossman authored Jul 15, 2022
1 parent b1ec1ed commit 805a155
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .env
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,5 @@ FORCE_MIGRATE_SECRET_STORE=false
METRIC_CLIENT=
# Useful only when metric client is set to be otel. Must start with http:// or https://.
OTEL_COLLECTOR_ENDPOINT="http://host.docker.internal:4317"

USE_STREAM_CAPABLE_STATE=false
1 change: 1 addition & 0 deletions charts/airbyte/templates/env-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,4 @@ data:
ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS: ""
ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS: ""
WORKFLOW_FAILURE_RESTART_DELAY_SECONDS: ""
USE_STREAM_CAPABLE_STATE: "false"
5 changes: 5 additions & 0 deletions charts/airbyte/templates/worker/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@ spec:
configMapKeyRef:
name: {{ include "common.names.fullname" . }}-env
key: WORKFLOW_FAILURE_RESTART_DELAY_SECONDS
- name: USE_STREAM_CAPABLE_STATE
valueFrom:
configMapKeyRef:
name: { { include "common.names.fullname" . } }-env
key: USE_STREAM_CAPABLE_STATE
{{- if .Values.worker.extraEnv }}
{{ .Values.worker.extraEnv | toYaml | nindent 8 }}
{{- end }}
Expand Down
1 change: 1 addition & 0 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ services:
- ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS=${ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS}
- ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS=${ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS}
- WORKFLOW_FAILURE_RESTART_DELAY_SECONDS=${WORKFLOW_FAILURE_RESTART_DELAY_SECONDS}
- USE_STREAM_CAPABLE_STATE=${USE_STREAM_CAPABLE_STATE}
volumes:
- /var/run/docker.sock:/var/run/docker.sock
- workspace:${WORKSPACE_ROOT}
Expand Down
2 changes: 2 additions & 0 deletions kube/overlays/dev-integration-test/.env
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,5 @@ ACTIVITY_MAX_ATTEMPT=
ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS=
ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS=
WORKFLOW_FAILURE_RESTART_DELAY_SECONDS=

USE_STREAM_CAPABLE_STATE=false
2 changes: 2 additions & 0 deletions kube/overlays/dev/.env
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,5 @@ ACTIVITY_MAX_ATTEMPT=
ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS=
ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS=
WORKFLOW_FAILURE_RESTART_DELAY_SECONDS=

USE_STREAM_CAPABLE_STATE=false
2 changes: 2 additions & 0 deletions kube/overlays/stable-with-resource-limits/.env
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,5 @@ ACTIVITY_MAX_ATTEMPT=
ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS=
ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS=
WORKFLOW_FAILURE_RESTART_DELAY_SECONDS=

USE_STREAM_CAPABLE_STATE=false
2 changes: 2 additions & 0 deletions kube/overlays/stable/.env
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,5 @@ ACTIVITY_MAX_ATTEMPT=
ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS=
ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS=
WORKFLOW_FAILURE_RESTART_DELAY_SECONDS=

USE_STREAM_CAPABLE_STATE=false
5 changes: 5 additions & 0 deletions kube/resources/worker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,11 @@ spec:
configMapKeyRef:
name: airbyte-env
key: WORKFLOW_FAILURE_RESTART_DELAY_SECONDS
- name: USE_STREAM_CAPABLE_STATE
valueFrom:
configMapKeyRef:
name: airbyte-env
key: USE_STREAM_CAPABLE_STATE
ports:
- containerPort: 9000 # for heartbeat server
- containerPort: 9001 # start temporal worker port pool
Expand Down

0 comments on commit 805a155

Please sign in to comment.