ci-connector-ops: change required reviewers logic (#21158)

tools/ci_connector_ops/ci_connector_ops/sat_config_checks.py

@@ -51,17 +51,16 @@ def find_changed_ga_connectors() -> List[str]:
     return [connector_name for connector_name in changed_connector_names if utils.get_connector_release_stage(connector_name) == "generally_available"]
 
 def find_mandatory_reviewers() -> List[Union[str, Dict[str, List]]]:
-    teams = []
     ga_connector_changes = find_changed_ga_connectors()
     backward_compatibility_changes = utils.get_changed_acceptance_test_config(diff_regex="disable_for_version")
     test_strictness_level_changes = utils.get_changed_acceptance_test_config(diff_regex="test_strictness_level")
-    if ga_connector_changes:
-        teams += GA_CONNECTOR_REVIEWERS
     if backward_compatibility_changes:
-        teams += [{"any-of": list(BACKWARD_COMPATIBILITY_REVIEWERS)}]
+        return [{"any-of": list(BACKWARD_COMPATIBILITY_REVIEWERS)}]
     if test_strictness_level_changes:
-        teams += [{"any-of": list(TEST_STRICTNESS_LEVEL_REVIEWERS)}]
-    return teams
+        return [{"any-of": list(TEST_STRICTNESS_LEVEL_REVIEWERS)}]
+    if ga_connector_changes:
+        return list(GA_CONNECTOR_REVIEWERS)
+    return []
 
 def check_test_strictness_level():
     connectors_with_bad_strictness_level = find_connectors_with_bad_strictness_level()

tools/ci_connector_ops/tests/test_sat_config_checks.py

@@ -61,7 +61,7 @@ def ga_connector_file_change_expected_team(tmp_path, ga_connector_file):
 
 @pytest.fixture
 def ga_connector_backward_compatibility_file_change(tmp_path, ga_connector_file):
-    expected_teams = list(sat_config_checks.GA_CONNECTOR_REVIEWERS) + [{"any-of": list(sat_config_checks.BACKWARD_COMPATIBILITY_REVIEWERS)}]
+    expected_teams = [{"any-of": list(sat_config_checks.BACKWARD_COMPATIBILITY_REVIEWERS)}]
     backup_path = tmp_path / "ga_acceptance_test_config.backup"
     shutil.copyfile(ga_connector_file, backup_path)
     with open(ga_connector_file, "a") as ga_acceptance_test_config_file:
@@ -71,7 +71,7 @@ def ga_connector_backward_compatibility_file_change(tmp_path, ga_connector_file)
 
 @pytest.fixture
 def ga_connector_test_strictness_level_file_change(tmp_path, ga_connector_file):
-    expected_teams = list(sat_config_checks.GA_CONNECTOR_REVIEWERS) + [{"any-of": list(sat_config_checks.TEST_STRICTNESS_LEVEL_REVIEWERS)}]
+    expected_teams = [{"any-of": list(sat_config_checks.TEST_STRICTNESS_LEVEL_REVIEWERS)}]
     backup_path = tmp_path / "ga_acceptance_test_config.backup"
     shutil.copyfile(ga_connector_file, backup_path)
     with open(ga_connector_file, "a") as ga_acceptance_test_config_file: