🪟 🔧 Add typings to mock data (#19022)

* refactor mockConnection to TS * refactor mockDestination to TS * refactor mockWorkspace to TS
airbytehq · Nov 7, 2022 · 41a12f6 · 41a12f6
1 parent 3aacda4
commit 41a12f6
Show file tree

Hide file tree

Showing 11 changed files with 738 additions and 749 deletions.
diff --git a/airbyte-webapp/src/components/CreateConnection/CreateConnectionForm.test.tsx b/airbyte-webapp/src/components/CreateConnection/CreateConnectionForm.test.tsx
@@ -3,18 +3,17 @@ import { act, render as tlr } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import React from "react";
 import selectEvent from "react-select-event";
-import mockConnection from "test-utils/mock-data/mockConnection.json";
-import mockDest from "test-utils/mock-data/mockDestinationDefinition.json";
+import { mockConnection } from "test-utils/mock-data/mockConnection";
+import { mockDestination } from "test-utils/mock-data/mockDestination";
 import { TestWrapper } from "test-utils/testutils";
 
-import { AirbyteCatalog } from "core/request/AirbyteClient";
 import { defaultFeatures, FeatureItem } from "hooks/services/Feature";
 import * as sourceHook from "hooks/services/useSourceHook";
 
 import { CreateConnectionForm } from "./CreateConnectionForm";
 
 jest.mock("services/connector/DestinationDefinitionSpecificationService", () => ({
-  useGetDestinationDefinitionSpecification: () => mockDest,
+  useGetDestinationDefinitionSpecification: () => mockDestination,
 }));
 
 jest.mock("services/workspaces/WorkspacesService", () => ({
@@ -40,7 +39,7 @@ describe("CreateConnectionForm", () => {
   const baseUseDiscoverSchema = {
     schemaErrorStatus: null,
     isLoading: false,
-    schema: mockConnection.syncCatalog as AirbyteCatalog,
+    schema: mockConnection.syncCatalog,
     catalogId: "",
     onDiscoverSchema: () => Promise.resolve(),
   };

diff --git a/airbyte-webapp/src/hooks/services/ConnectionEdit/ConnectionEditService.test.tsx b/airbyte-webapp/src/hooks/services/ConnectionEdit/ConnectionEditService.test.tsx
@@ -1,8 +1,8 @@
 import { act, renderHook } from "@testing-library/react-hooks";
 import React from "react";
-import mockConnection from "test-utils/mock-data/mockConnection.json";
-import mockDest from "test-utils/mock-data/mockDestinationDefinition.json";
-import mockWorkspace from "test-utils/mock-data/mockWorkspace.json";
+import { mockConnection } from "test-utils/mock-data/mockConnection";
+import { mockDestination } from "test-utils/mock-data/mockDestination";
+import { mockWorkspace } from "test-utils/mock-data/mockWorkspace";
 import { TestWrapper } from "test-utils/testutils";
 
 import { WebBackendConnectionUpdate } from "core/request/AirbyteClient";
@@ -11,7 +11,7 @@ import { useConnectionFormService } from "../ConnectionForm/ConnectionFormServic
 import { ConnectionEditServiceProvider, useConnectionEditService } from "./ConnectionEditService";
 
 jest.mock("services/connector/DestinationDefinitionSpecificationService", () => ({
-  useGetDestinationDefinitionSpecification: () => mockDest,
+  useGetDestinationDefinitionSpecification: () => mockDestination,
 }));
 
 jest.mock("services/workspaces/WorkspacesService", () => ({

diff --git a/airbyte-webapp/src/hooks/services/ConnectionForm/ConnectionFormService.test.tsx b/airbyte-webapp/src/hooks/services/ConnectionForm/ConnectionFormService.test.tsx
@@ -1,11 +1,10 @@
 import { act, renderHook } from "@testing-library/react-hooks";
 import React from "react";
-import mockConnection from "test-utils/mock-data/mockConnection.json";
-import mockDest from "test-utils/mock-data/mockDestinationDefinition.json";
-import mockWorkspace from "test-utils/mock-data/mockWorkspace.json";
+import { mockConnection } from "test-utils/mock-data/mockConnection";
+import { mockDestination } from "test-utils/mock-data/mockDestination";
+import { mockWorkspace } from "test-utils/mock-data/mockWorkspace";
 import { TestWrapper } from "test-utils/testutils";
 
-import { AirbyteCatalog, WebBackendConnectionRead } from "core/request/AirbyteClient";
 import { FormError } from "utils/errorStatusMessage";
 
 import {
@@ -15,7 +14,7 @@ import {
 } from "./ConnectionFormService";
 
 jest.mock("services/connector/DestinationDefinitionSpecificationService", () => ({
-  useGetDestinationDefinitionSpecification: () => mockDest,
+  useGetDestinationDefinitionSpecification: () => mockDestination,
 }));
 
 jest.mock("services/workspaces/WorkspacesService", () => ({
@@ -37,7 +36,7 @@ describe("ConnectionFormService", () => {
 
   it("should take a partial Connection", async () => {
     const partialConnection: ConnectionOrPartialConnection = {
-      syncCatalog: mockConnection.syncCatalog as AirbyteCatalog,
+      syncCatalog: mockConnection.syncCatalog,
       source: mockConnection.source,
       destination: mockConnection.destination,
     };
@@ -57,7 +56,7 @@ describe("ConnectionFormService", () => {
     const { result } = renderHook(useConnectionFormService, {
       wrapper: Wrapper,
       initialProps: {
-        connection: mockConnection as WebBackendConnectionRead,
+        connection: mockConnection,
         mode: "create",
         refreshSchema,
       },
@@ -71,7 +70,7 @@ describe("ConnectionFormService", () => {
       const { result } = renderHook(useConnectionFormService, {
         wrapper: Wrapper,
         initialProps: {
-          connection: mockConnection as WebBackendConnectionRead,
+          connection: mockConnection,
           mode: "create",
           refreshSchema,
         },
@@ -86,7 +85,7 @@ describe("ConnectionFormService", () => {
       const { result } = renderHook(useConnectionFormService, {
         wrapper: Wrapper,
         initialProps: {
-          connection: mockConnection as WebBackendConnectionRead,
+          connection: mockConnection,
           mode: "create",
           refreshSchema,
         },
@@ -99,7 +98,7 @@ describe("ConnectionFormService", () => {
       const { result } = renderHook(useConnectionFormService, {
         wrapper: Wrapper,
         initialProps: {
-          connection: mockConnection as WebBackendConnectionRead,
+          connection: mockConnection,
           mode: "create",
           refreshSchema,
         },
@@ -112,7 +111,7 @@ describe("ConnectionFormService", () => {
       const { result } = renderHook(useConnectionFormService, {
         wrapper: Wrapper,
         initialProps: {
-          connection: mockConnection as WebBackendConnectionRead,
+          connection: mockConnection,
           mode: "create",
           refreshSchema,
         },

diff --git a/...ebapp/src/pages/ConnectionPage/pages/ConnectionItemPage/ConnectionReplicationTab.test.tsx b/...ebapp/src/pages/ConnectionPage/pages/ConnectionItemPage/ConnectionReplicationTab.test.tsx
@@ -5,9 +5,9 @@ import { render as tlr, act } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import React, { Suspense } from "react";
 import selectEvent from "react-select-event";
-import mockConnection from "test-utils/mock-data/mockConnection.json";
-import mockDest from "test-utils/mock-data/mockDestinationDefinition.json";
-import mockWorkspace from "test-utils/mock-data/mockWorkspace.json";
+import { mockConnection } from "test-utils/mock-data/mockConnection";
+import { mockDestination } from "test-utils/mock-data/mockDestination";
+import { mockWorkspace } from "test-utils/mock-data/mockWorkspace";
 import { mockWorkspaceId } from "test-utils/mock-data/mockWorkspaceId";
 import { TestWrapper } from "test-utils/testutils";
 
@@ -19,7 +19,7 @@ import * as connectionHook from "hooks/services/useConnectionHook";
 import { ConnectionReplicationTab } from "./ConnectionReplicationTab";
 
 jest.mock("services/connector/DestinationDefinitionSpecificationService", () => ({
-  useGetDestinationDefinitionSpecification: () => mockDest,
+  useGetDestinationDefinitionSpecification: () => mockDestination,
 }));
 jest.setTimeout(10000);