Skip to content

Commit

Permalink
correct project titles
Browse files Browse the repository at this point in the history
  • Loading branch information
@antixar
antixar committed Jan 10, 2022
1 parent 1d64137 commit 3f1f2cb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/actions/ci-tests-runner/action.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ runs:
echo "::set-output name=sq-report::$body"
- name: Add Comment
if: ${{ inputs.module-lang == 'py' && github.event_name == 'pull_request' }}
if: ${{ github.event_name == 'pull_request' }}
uses: peter-evans/commit-comment@v1
with:
body: ${{ steps.generate-sq-report.outputs.sq-report }}
Expand Down
2 changes: 1 addition & 1 deletion tools/ci_code_validator/ci_sonar_qube/sonar_qube_api.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def __search_project(self, project_name: str) -> Optional[Mapping[str, Any]]:
return exists_projects[0]

def prepare_project_settings(self, project_name: str) -> Mapping[str, str]:
title = re.sub('[:_-]', ' ', project_name).title()
title = re.sub('[:_-]', ' ', project_name).replace("connectors_", "").title()
if self._pr_id:
title += f"(#{self._pr_id})"

Expand Down

3 comments on commit 3f1f2cb

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube report for Airbyte Connectors Source Github(#8362)

Measures

Name Value Name Value Name Value
Quality Gate Status OK Bugs 0 Reliability Rating A
Lines of Code 815 Security Rating A Coverage 40.1
Lines to Cover 613 Vulnerabilities 0 Duplicated Blocks 0
Duplicated Lines (%) 0.0 Code Smells 13 Blocker Issues 0
Critical Issues 3 Major Issues 4 Minor Issues 6

Detected Issues

Rule File Description Message
python:isort_need_format (MINOR) unit_tests/test_stream.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
python:black_need_format (MINOR) setup.py Please run one of the commands: "black --config ./pyproject.toml <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
python:S5886 (MAJOR) source_github/streams.py:66 Function return types should be consistent with their type hint Return a value of type "Union[int, float]" instead of "NoneType" or update function "backoff_time" type hint.
python:S2638 (CRITICAL) source_github/streams.py:712 Method overrides should not change contracts Add missing parameters organization.
python:isort_need_format (MINOR) unit_tests/test_source.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
python:isort_need_format (MINOR) unit_tests/unit_test.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
python:isort_need_format (MINOR) main.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
python:mypy_unknown (MINOR) main.py Unknown error Duplicate module named "main" (also at "./fixtures/main.py")
python:S3776 (CRITICAL) source_github/streams.py:73 Cognitive Complexity of functions should not be too high Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed.
flake8:E501 (MAJOR) fixtures/github.py:22 line too long (82 > 79 characters) line too long (151 > 140 characters)
python:S5797 (CRITICAL) fixtures/github.py:79 Constants should not be used as conditions Replace this expression; used as a condition it will always be constant.
python:S112 (MAJOR) source_github/source.py:68 "Exception" and "BaseException" should not be raised Replace this generic exception class with a more specific one.
flake8:C901 (MAJOR) source_github/streams.py:73 flake8:C901 'GithubStream.read_records' is too complex (13)

Coverage (40.1%)

File Coverage File Coverage
fixtures/github.py 0.0 fixtures/main.py 0.0
integration_tests/acceptance.py 0.0 main.py 0.0
setup.py 0.0 source_github/init.py 100.0
source_github/source.py 55.3 source_github/streams.py 55.5
unit_tests/test_source.py 0.0 unit_tests/test_stream.py 0.0
unit_tests/unit_test.py 0.0

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube report for Airbyte Connectors Source Airtable(#8362)

Measures

Name Value Name Value Name Value
Vulnerabilities 0 Duplicated Lines (%) 0.0 Security Rating A
Bugs 0 Lines to Cover 186 Coverage 45.2
Lines of Code 242 Quality Gate Status ERROR Code Smells 27
Reliability Rating A Duplicated Blocks 0 Blocker Issues 0
Critical Issues 0 Major Issues 6 Minor Issues 21

Detected Issues

Rule File Description Message
python:black_need_format (MINOR) source_airtable/source.py Please run one of the commands: "black --config ./pyproject.toml <path_to_updated_folder>" or "./gradlew format" 2 code part(s) should be updated.
python:isort_need_format (MINOR) source_airtable/source.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 2 code part(s) should be updated.
flake8:F401 (MAJOR) source_airtable/source.py:8 module imported but unused 'pathlib' imported but unused
python:black_need_format (MINOR) setup.py Please run one of the commands: "black --config ./pyproject.toml <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
python:mypy_no_untyped_def (MINOR) integration_tests/acceptance.py:12 Check that every function has an annotation Function is missing a return type annotation . Code line: def connector_setup():
python:isort_need_format (MINOR) main.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
python:mypy_import (MINOR) source_airtable/helpers.py:8 Require that imported module can be found or has stubs Library stubs not installed for "requests" (or incompatible with Python 3.7) . Code line: import requests
python:S112 (MAJOR) source_airtable/helpers.py:23 "Exception" and "BaseException" should not be raised Replace this generic exception class with a more specific one.
python:S112 (MAJOR) source_airtable/helpers.py:25 "Exception" and "BaseException" should not be raised Replace this generic exception class with a more specific one.
python:S112 (MAJOR) source_airtable/helpers.py:27 "Exception" and "BaseException" should not be raised Replace this generic exception class with a more specific one.
python:mypy_no_any_return (MINOR) source_airtable/helpers.py:30 Reject returning value with "Any" type if return type is not "Any" Returning Any from function declared to return "Dict[str, Any]" . Code line: return record
python:mypy_return_value (MINOR) source_airtable/helpers.py:48 Check that return value is compatible with signature Incompatible return value type (got "Dict[str, Collection[str]]", expected "Dict[str, str]") . Code line: return json_schema
python:mypy_import (MINOR) source_airtable/source.py:9 Require that imported module can be found or has stubs Library stubs not installed for "requests" (or incompatible with Python 3.7) . Code line: import requests
flake8:E302 (MAJOR) source_airtable/source.py:20 expected 2 blank lines, found 0 expected 2 blank lines, found 0
python:mypy_no_untyped_def (MINOR) source_airtable/source.py:25 Check that every function has an annotation Function is missing a type annotation for one or more arguments . Code line: def init(self, base_id: str, table_name: str, schema, **kwargs...
python:mypy_no_untyped_def (MINOR) source_airtable/source.py:32 Check that every function has an annotation Function is missing a return type annotation . Code line: def name(self):
python:mypy_no_any_return (MINOR) source_airtable/source.py:36 Reject returning value with "Any" type if return type is not "Any" Returning Any from function declared to return "Mapping[str, Any]" . Code line: return self.schema
python:mypy_valid_type (MINOR) source_airtable/source.py:46 Check that type (annotation) is valid Function "builtins.any" is not valid as a type . Code line: ...e: Mapping[str, Any], stream_slice: Mapping[str, any] = None, next_pag...
python:mypy_return_value (MINOR) source_airtable/source.py:49 Check that return value is compatible with signature Incompatible return value type (got "Mapping[str, Any]", expected "MutableMapping[str, Any]") . Code line: return next_page_token
python:mypy_no_untyped_def (MINOR) source_airtable/source.py:52 Check that every function has an annotation Function is missing a type annotation . Code line: def process_records(self, records):
python:mypy_no_untyped_def (MINOR) source_airtable/source.py:58 Check that every function has an annotation Function is missing a type annotation for one or more arguments . Code line: def parse_response(self, response: requests.Response, **kwargs) ->...
flake8:E303 (MAJOR) source_airtable/source.py:64 too many blank lines (3) too many blank lines (2)
python:mypy_no_untyped_def (MINOR) source_airtable/source.py:74 Check that every function has an annotation Function is missing a type annotation for one or more arguments . Code line: def check_connection(self, logger, config) -> Tuple[bool, any]:
python:mypy_valid_type (MINOR) source_airtable/source.py:74 Check that type (annotation) is valid Function "builtins.any" is not valid as a type . Code line: def check_connection(self, logger, config) -> Tuple[bool, any]:
python:mypy_no_untyped_def (MINOR) source_airtable/source.py:83 Check that every function has an annotation Function is missing a type annotation for one or more arguments . Code line: def discover(self, logger: AirbyteLogger, config) -> AirbyteCatalo...
python:isort_need_format (MINOR) unit_tests/test_helpers.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.
python:isort_need_format (MINOR) unit_tests/test_source.py Please run one of the commands: "isort <path_to_updated_folder>" or "./gradlew format" 1 code part(s) should be updated.

Coverage (45.2%)

File Coverage File Coverage
integration_tests/acceptance.py 0.0 main.py 0.0
setup.py 0.0 source_airtable/init.py 100.0
source_airtable/helpers.py 93.8 source_airtable/source.py 70.3
unit_tests/conftest.py 0.0 unit_tests/test_helpers.py 0.0
unit_tests/test_source.py 0.0

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube report for Airbyte Connectors Destination Mongodb(#8362)

Measures

Name Value Name Value Name Value
Reliability Rating A Quality Gate Status OK Vulnerabilities 0
Duplicated Blocks 0 Lines of Code 348 Bugs 0
Security Rating A Duplicated Lines (%) 0.0 Lines to Cover 162
Code Smells 3 Coverage 0.0 Blocker Issues 0
Critical Issues 1 Major Issues 1 Minor Issues 0

Detected Issues

Rule File Description Message
java:S5803 (CRITICAL) mongodb/MongodbDestination.java:61 Class members annotated with "@VisibleForTesting" should not be accessed from production code Remove this usage of "MongodbNameTransformer", it is annotated with @VisibleForTesting and should not be accessed from production code.
java:S1135 (INFO) mongodb/MongodbRecordConsumer.java:61 Track uses of "TODO" tags Complete the task associated to this TODO comment.
java:S112 (MAJOR) mongodb/MongodbRecordConsumer.java:139 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.

Coverage (0.0%)

File Coverage File Coverage
src/main/java/io/airbyte/integrations/destination/mongodb/exception/MongodbDatabaseException.java 0.0 src/main/java/io/airbyte/integrations/destination/mongodb/MongodbDestination.java 0.0
src/main/java/io/airbyte/integrations/destination/mongodb/MongodbNameTransformer.java 0.0 src/main/java/io/airbyte/integrations/destination/mongodb/MongodbRecordConsumer.java 0.0
src/main/java/io/airbyte/integrations/destination/mongodb/MongodbWriteConfig.java 0.0

Please sign in to comment.