chore: add deptry dependency analysis check
#408
Merged
+198
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
🤖 Devin AI EngineerOriginal prompt from Aaron: I'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Deptry Analysis ResultsLocal deptry run results (click to expand)The deptry configuration in pyproject.toml successfully handles:
This configuration follows the pattern used in PyAirbyte. The CI failures are expected for a new workflow. I'll continue monitoring and address any specific issues that arise. |
|
aside - Devin added ignore rules to all the failing tests. Here's the original output: Show/Hide
|
aaronsteers
reviewed
Mar 11, 2025
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
…oetry Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
aaronsteers
reviewed
Mar 11, 2025
aaronsteers
reviewed
Mar 11, 2025
aaronsteers
reviewed
Mar 11, 2025
aaronsteers
reviewed
Mar 11, 2025
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
aaronsteers
reviewed
Mar 11, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
aaronsteers
reviewed
Mar 11, 2025
|
/poetry-lock
|
aaronsteers
changed the title
deptry dependency analysis tests
aaronsteers
changed the title
deptry dependency analysis testsdeptry dependency analysis check
aaronsteers
approved these changes
Mar 12, 2025
aaronsteers
reviewed
Mar 12, 2025
aaronsteers
reviewed
Mar 12, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR integrates dependency analysis using deptry into the project’s CI and updates dependency declarations in the pyproject.toml file.
- Added a new GitHub Actions workflow to run deptry on pushes and pull requests.
- Updated pyproject.toml with new dependencies, TODO comments for potential cleanup, and a [tool.deptry] configuration to ignore specific dependency issues.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/python_dependency_analysis.yml | Added a CI job to run deptry for dependency analysis. |
| pyproject.toml | Updated dependency declarations and added deptry configuration. |
Comments suppressed due to low confidence (2)
pyproject.toml:56
- Typo in the comment: 'depedencies' should be corrected to 'dependencies'.
# Extras depedencies
pyproject.toml:57
- [nitpick] If 'avro' is only used in unit tests, consider moving it to development dependencies to avoid potential production usage warnings.
+avro = { version = ">=1.11.2,<1.13.0", optional = true } # TODO: Move into dev dependencies if only used in tests
bnchrch
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added deptry tests to check for unused, missing, and transitive dependencies in the CDK, following the example in PyAirbyte's implementation.
The deptry implementation helps ensure that unused or undeclared dependencies are found during development.
Link to Devin run: https://app.devin.ai/sessions/8128d7fb60564b8bafc27ffe77a00640
Summary (from AJ)
deptryas a dev dependency.deptryerrors.deptrybut doesn't try to fix those yet. (Keep risk low and chance of successful merge high.)avrois an interesting case, where we seem to have fully replaced it in main code withfastavro, butavroitself is still used in some unit tests. So, to handle that exception, we can move it to be a test dependency or refactor the test to usefastavro.deptryPyAirbyte#534