Skip to content

Commit

Permalink
Handled nitpick comments by rabbit
Browse files Browse the repository at this point in the history
Handled nitpick comments by rabbit
  • Loading branch information
rpopov authored Jan 9, 2025
1 parent f7f19be commit e5b9e5c
Showing 1 changed file with 15 additions and 15 deletions.
30 changes: 15 additions & 15 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,52 +18,52 @@ Here are some tips to get started using the project dependencies and development

Fedora 41:

```
```bash
sudo dnf install python3.11
```

2. [Install pip](https://pip.pypa.io/en/stable/installation/)

Fedora 41:

```
```bash
sudo dnf install pip
```

3. [Install pipx](https://pipx.pypa.io/stable/installation/)

Fedora 41:

```
```bash
sudo dnf install pipx
```

4. [Install Poetry](https://python-poetry.org/docs/#):

```
```bash
pipx install poetry
```

or

```
```bash
curl -sSL https://install.python-poetry.org | python3 -
```
Fedora 41:

```
```bash
sudo dnf install poetry
```

5. In the **airbyte-python-cdk project** install [Poe the Poet](https://poethepoet.natn.io/) and unit tests' prerequisites:

```
```bash
poetry install --all-extras
```

6. If your operating system is RHEL or compatible, execute:

```
```bash
# just for the current session, until restart
sudo modprobe iptable_nat

Expand Down Expand Up @@ -141,7 +141,7 @@ In this project, the [GitHub pipelines](.github/workflows/connector-tests.yml) r

- In the `airbyte` project run:

```
```bash
cd airbyte/airbyte-integrations/bases/connector-acceptance-test/
poetry install
```
Expand All @@ -155,7 +155,7 @@ airbyte_cdk = { path = "../../../../airbyte-python-cdk", develop = true }

- In `airbyte/airbyte-integrations/connectors/<test connector>` reinstall `airbyte_cdk` from your local working directory:

```
```bash
cd airbyte/airbyte-integrations/connectors/<test connector>
poetry install
```
Expand All @@ -171,7 +171,7 @@ poetry install
`
Example contents:

```
```json
{
"shop": "nw0ipt-vr",
"start_date": "2020-11-01",
Expand All @@ -190,7 +190,7 @@ poetry install

- Run the connector's tests (see the connector's README.md)

```
```bash
cd airbyte/airbyte-integrations/connectors/<connector name>

poetry run <connector name> spec
Expand All @@ -202,7 +202,7 @@ poetry run pytest

Example:

```
```bash
cd airbyte/airbyte-integrations/connectors/source-shopify

poetry run source-shopify spec
Expand All @@ -214,15 +214,15 @@ poetry run pytest

- Run the acceptance tests locally:

```
```bash
cd airbyte/airbyte-integrations/bases/connector-acceptance-test

poetry run pytest -p connector_acceptance_test.plugin --acceptance-test-config=../../connectors/<connector name>
```

Example:

```
```bash
poetry run pytest -p connector_acceptance_test.plugin --acceptance-test-config=../../connectors/source-shopify

# or with debug option:
Expand Down

0 comments on commit e5b9e5c

Please sign in to comment.