-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix position calculations for 'vertical' mode #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you add a regression test that would have caught this?
I'm going to provide new PR with fixing vertical slider in storybook soon. Can we merge this PR now and release a package, because the fix is obvious and very important for my current project? |
I’d prefer not to merge a fix without a regression test in the same PR. It may be obvious looking at the diff, but it was non-obvious enough to be missed previously. |
@ljharb , I've added tests, check please. |
bb41707
to
ea18f80
Compare
Would be nice to have the fix merged soon (-; |
@majapw could you please check the PR? |
@ljharb could you help the PR to be merged? |
@mrkosima the only way for this PR to be merged is to wait patiently for maja to review and merge it :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Sorry for the long delay in reviewing!
@ljharb is it possible to make a 3.0.2 release with this fix? |
Released! I will do better next time at quick turnaround. :) |
This PR fixes handle's position calculations for vertical mode.