-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove connector close workaround for older Python versions #9818
Conversation
The TODO is fixed on all supported versions python/cpython#84132
I think we need to drop the |
CodSpeed Performance ReportMerging #9818 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9818 +/- ##
==========================================
- Coverage 98.69% 98.69% -0.01%
==========================================
Files 118 118
Lines 36026 36017 -9
Branches 4280 4279 -1
==========================================
- Hits 35557 35548 -9
Misses 315 315
Partials 154 154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The TODO is fixed on all supported versions which was added in #6321
python/cpython#84132
Note this code is not present in 3.x