Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connector close workaround for older Python versions #9818

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 11, 2024

The TODO is fixed on all supported versions which was added in #6321

python/cpython#84132

Note this code is not present in 3.x

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 11, 2024
@bdraco bdraco requested a review from asvetlov as a code owner November 11, 2024 16:45
@bdraco bdraco changed the title Remove connector close workaround for other Python versions Remove connector close workaround for older Python versions Nov 11, 2024
@bdraco bdraco added backport:skip Skip backport bot and removed backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 11, 2024
@bdraco bdraco marked this pull request as draft November 11, 2024 17:03
@bdraco
Copy link
Member Author

bdraco commented Nov 11, 2024

I think we need to drop the test_release_proto_closed_future test as well

Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #9818 will not alter performance

Comparing remove_todo_connector (12a2ba5) with master (26f096d)

Summary

✅ 17 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review November 11, 2024 17:12
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (7a46f64) to head (12a2ba5).
Report is 664 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9818      +/-   ##
==========================================
- Coverage   98.69%   98.69%   -0.01%     
==========================================
  Files         118      118              
  Lines       36026    36017       -9     
  Branches     4280     4279       -1     
==========================================
- Hits        35557    35548       -9     
  Misses        315      315              
  Partials      154      154              
Flag Coverage Δ
CI-GHA 98.58% <ø> (-0.01%) ⬇️
OS-Linux 98.27% <ø> (-0.01%) ⬇️
OS-Windows 96.05% <ø> (-0.01%) ⬇️
OS-macOS 97.34% <ø> (-0.01%) ⬇️
Py-3.10.11 97.19% <ø> (-0.02%) ⬇️
Py-3.10.15 97.80% <ø> (+0.05%) ⬆️
Py-3.11.10 97.78% <ø> (-0.07%) ⬇️
Py-3.11.9 97.24% <ø> (-0.02%) ⬇️
Py-3.12.7 98.33% <ø> (-0.01%) ⬇️
Py-3.13.0 98.32% <ø> (-0.01%) ⬇️
Py-3.9.13 97.11% <ø> (-0.01%) ⬇️
Py-3.9.20 97.66% <ø> (-0.01%) ⬇️
Py-pypy7.3.16 97.28% <ø> (+<0.01%) ⬆️
VM-macos 97.34% <ø> (-0.01%) ⬇️
VM-ubuntu 98.27% <ø> (-0.01%) ⬇️
VM-windows 96.05% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 11, 2024 17:27
@bdraco bdraco merged commit 0f18900 into master Nov 11, 2024
37 of 38 checks passed
@bdraco bdraco deleted the remove_todo_connector branch November 11, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants