ResourceAdapter is broken #794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -715,7 +716,7 @@ def test_resource_adapter_resolve_wildcard(self): | |||
| resource = route.resource | |||
| match_info, allowed = self.loop.run_until_complete( | |||
| resource.resolve('GET', '/path')) | |||
| self.assertEqual(allowed, {'*'}) # TODO: expand wildcard | |||
| self.assertEqual(allowed, set()) # TODO: expand wildcard | |||
There was a problem hiding this comment.
I guess this TODO statement is useful no longer.
|
Does nobody care about the error? Actually, for now, AIOHTTP doesn't return 404 as well (for unknown resources). Is it normal? |
|
@klen It could be not a problem. See webmachine flow for example. However, I'm not aware about the underlying idea. cc @asvetlov |
|
👍 |
|
Guys, I'm traveling during last week. Will take a look after returning home. |
2 tasks
|
I don't that See #826 for proper fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, if we have any route which has been added from
router.register_route, by example anyStaticRoutethen 404 URLs raise 405 (GET /unknown_url_404 --> 405!)It happens because ResourceAdapter always returns
allowed_methods. The PR fixes the problem.