Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting cookies for individual request #3396

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Add support for setting cookies for individual request #3396

merged 2 commits into from
Nov 30, 2018

Conversation

perkfly
Copy link
Contributor

@perkfly perkfly commented Nov 19, 2018

What do these changes do?

support to add additional cookies per request when using aiohttp.ClientSession.request

Are there changes in behavior for the user?

User could now use cookies per request

Related issue number

#2387

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #3396 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3396      +/-   ##
==========================================
- Coverage   98.01%   97.94%   -0.07%     
==========================================
  Files          44       44              
  Lines        8500     8511      +11     
  Branches     1377     1382       +5     
==========================================
+ Hits         8331     8336       +5     
- Misses         70       74       +4     
- Partials       99      101       +2
Impacted Files Coverage Δ
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/web_fileresponse.py 96.51% <0%> (-1.75%) ⬇️
aiohttp/client_reqrep.py 97.28% <0%> (-0.16%) ⬇️
aiohttp/streams.py 99.22% <0%> (+0.01%) ⬆️
aiohttp/web.py 98.97% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcde126...75d0223. Read the comment docs.

@webknjaz webknjaz removed their request for review November 19, 2018 21:49
@asvetlov asvetlov merged commit 59c27c6 into aio-libs:master Nov 30, 2018
@asvetlov
Copy link
Member

Thanks for the contribution, @yifeikong !

@lock
Copy link

lock bot commented Nov 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Nov 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 30, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants