Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web.FileResponse overriding user supplied Content-Type #2319

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Fix web.FileResponse overriding user supplied Content-Type #2319

merged 1 commit into from
Oct 13, 2017

Conversation

thelink2012
Copy link
Contributor

What do these changes do?

If the user modifies either the web.FileResponse.content_type property, or the Content-Type header, the choice is now respected instead of guessing the content type from the file extension.

Are there changes in behavior for the user?

No notable changes should happen.

Related issue number

Fixes #2317

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes (no need I guess)
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the changes folder

@codecov-io
Copy link

Codecov Report

Merging #2319 into 2.2 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.2    #2319      +/-   ##
==========================================
+ Coverage   97.06%   97.06%   +<.01%     
==========================================
  Files          38       38              
  Lines        7691     7694       +3     
  Branches     1341     1342       +1     
==========================================
+ Hits         7465     7468       +3     
  Misses        102      102              
  Partials      124      124
Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 90.72% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60f3342...fc18aeb. Read the comment docs.

@asvetlov asvetlov merged commit fff0def into aio-libs:2.2 Oct 13, 2017
@asvetlov
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants