Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awaitable _CoroGuard and fix ClientSession.close warning message #2027

Merged
merged 8 commits into from
Jun 29, 2017

Conversation

litwisha
Copy link
Contributor

@litwisha litwisha commented Jun 27, 2017

What do these changes do?

  1. _CoroGuard. is awaitable.
  2. Fix warning message for ClientSession.close() method. (from ClientSession.close() is not coroutine to ClientSession.close() is coroutine)

Related issue number

#2026

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.

@litwisha litwisha changed the title Awaitable _CoroGuard and warn if ClientSession.close was awaited [WIP] Awaitable _CoroGuard and warn if ClientSession.close was awaited Jun 27, 2017
@asvetlov
Copy link
Member

Warning text should be fixed.
The guard encourages await session.close() usage while we should support just session.close() for a while for sake of backward compatibility.

@litwisha litwisha changed the title [WIP] Awaitable _CoroGuard and warn if ClientSession.close was awaited [WIP] Awaitable _CoroGuard and fix ClientSession.close warning message Jun 27, 2017
@codecov-io
Copy link

codecov-io commented Jun 27, 2017

Codecov Report

Merging #2027 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2027      +/-   ##
==========================================
+ Coverage   97.05%   97.05%   +<.01%     
==========================================
  Files          38       38              
  Lines        7700     7704       +4     
  Branches     1347     1348       +1     
==========================================
+ Hits         7473     7477       +4     
  Misses        103      103              
  Partials      124      124
Impacted Files Coverage Δ
aiohttp/helpers.py 96.9% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0957977...8a9c76f. Read the comment docs.

@litwisha litwisha changed the title [WIP] Awaitable _CoroGuard and fix ClientSession.close warning message Awaitable _CoroGuard and fix ClientSession.close warning message Jun 27, 2017
@asvetlov
Copy link
Member

Please update warning message as well

@asvetlov
Copy link
Member

Also please add a record in ./changes folder

@litwisha
Copy link
Contributor Author

@asvetlov I have completed all the notes. It seems to be ready for merge

@asvetlov
Copy link
Member

Thank you.
I'll process the PR a bit later.

@asvetlov asvetlov merged commit 47d077e into aio-libs:master Jun 29, 2017
@asvetlov
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants