-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Awaitable _CoroGuard and fix ClientSession.close
warning message
#2027
Conversation
ClientSession.close
was awaitedClientSession.close
was awaited
Warning text should be fixed. |
ClientSession.close
was awaitedClientSession.close
warning message
Codecov Report
@@ Coverage Diff @@
## master #2027 +/- ##
==========================================
+ Coverage 97.05% 97.05% +<.01%
==========================================
Files 38 38
Lines 7700 7704 +4
Branches 1347 1348 +1
==========================================
+ Hits 7473 7477 +4
Misses 103 103
Partials 124 124
Continue to review full report at Codecov.
|
ClientSession.close
warning messageClientSession.close
warning message
Please update warning message as well |
Also please add a record in |
@asvetlov I have completed all the notes. It seems to be ready for merge |
Thank you. |
Thanks! |
What do these changes do?
ClientSession.close()
method. (fromClientSession.close() is not coroutine
toClientSession.close() is coroutine
)Related issue number
#2026
Checklist
CONTRIBUTORS.txt