Expose setsockopt in TCPConnector API

[TimMenninger]

Optionally give tcp_sockopts to the constructor of TCPConnector, which will be a list of tuples of (level, optname, value). Each tuple is deconstructed and passed as arguments to .setsockopt. One such use case for this feature would be to modify the keepalive behavior leading up to considering a connection dead by setting TCP_KEEPIDLE, TCP_KEEPINTVL and TCP_KEEPCNT sockopts.

What do these changes do?

These changes allow the caller to pass arguments understood by <socket>.setsockopt to be applied to the socket created in TCPConnector.

Are there changes in behavior for the user?

The changes contained in this PR are opt-in by passing values in tcp_sockopts parameter to the TCPConnector class construction.

Is it a substantial burden for the maintainers to support this?

I sure hope not.

Related issue number

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES/ folder

  • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

  • if you don't have an issue number, change it to the pull request
    number after creating the PR

    • .bugfix: A bug fix for something the maintainers deemed an
      improper undesired behavior that got corrected to match
      pre-agreed expectations.
    • .feature: A new behavior, public APIs. That sort of stuff.
    • .deprecation: A declaration of future API removals and breaking
      changes in behavior.
    • .breaking: When something public is removed in a breaking way.
      Could be deprecated in an earlier release.
    • .doc: Notable updates to the documentation structure or build
      process.
    • .packaging: Notes for downstreams about unobvious side effects
      and tooling. Changes in the test invocation considerations and
      runtime assumptions.
    • .contrib: Stuff that affects the contributor experience. e.g.
      Running tests, building the docs, setting up the development
      environment.
    • .misc: Changes that are hard to assign to any of the above
      categories.

  • Make sure to use full sentences with correct case and punctuation,
    for example:

    Fixed issue with non-ascii contents in doctest text files
    -- by :user:`contributor-gh-handle`.

    Use the past tense or the present tense a non-imperative mood,
    referring to what's changed compared to the last released version
    of this project.

[codspeed-hq]

CodSpeed Performance Report

Merging #10474 will not alter performance

_{Comparing TimMenninger:setsockopts-tcpconnector (105f0b8) with master (60819de)}

Summary

✅ 47 untouched benchmarks

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (60819de) to head (105f0b8).
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #10474   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files         122      122           
  Lines       37209    37225   +16     
  Branches     2060     2063    +3     
=======================================
+ Hits        36727    36743   +16     
  Misses        335      335           
  Partials      147      147           

Flag	Coverage Δ
CI-GHA	98.58% <93.75%> (-0.01%)	⬇️
OS-Linux	98.25% <93.75%> (-0.01%)	⬇️
OS-Windows	96.18% <93.75%> (+<0.01%)	⬆️
OS-macOS	97.36% <93.75%> (-0.01%)	⬇️
Py-3.10.11	97.27% <87.50%> (-0.01%)	⬇️
Py-3.10.16	97.81% <87.50%> (-0.01%)	⬇️
Py-3.11.11	97.90% <87.50%> (+<0.01%)	⬆️
Py-3.11.9	97.36% <87.50%> (+<0.01%)	⬆️
Py-3.12.8	97.14% <87.50%> (-0.01%)	⬇️
Py-3.12.9	98.33% <87.50%> (-0.01%)	⬇️
Py-3.13.1	97.14% <87.50%> (-0.02%)	⬇️
Py-3.13.2	98.32% <87.50%> (-0.02%)	⬇️
Py-3.9.13	97.16% <87.50%> (+<0.01%)	⬆️
Py-3.9.21	97.69% <87.50%> (-0.01%)	⬇️
Py-pypy7.3.16	77.24% <87.50%> (-17.29%)	⬇️
VM-macos	97.36% <93.75%> (-0.01%)	⬇️
VM-ubuntu	98.25% <93.75%> (-0.01%)	⬇️
VM-windows	96.18% <93.75%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bdraco]

It looks like there is a conflict now.

Would you please update the PR description to better explain the use case and motivation for this change.

[Dreamsorcerer]

Seems like a reasonable addition to me, if there's good usecases for it.

[TimMenninger]

It looks like there is a conflict now.

Would you please update the PR description to better explain the use case and motivation for this change.

Updated with a sample use case taken directly from my own motivation for this change.

[patchback]

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/7379a866bb9fa41986a01aa6fff2a73a210b66de/pr-10474

Backported as #10486

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.