Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace reentry by importlib.metadata #4960

Closed

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented May 21, 2021

Note: this is a quick port of an earlier fix intended for testing;
pre-commit still fails because of one missing feature + we may want to
clean up the codebase a bit.

ltalirz added 2 commits May 21, 2021 18:27
Note: this is a quick port of an earlier fix intended for testing;
pre-commit still fails because of one missing feature + we may want to
clean up the codebase a bit.
@ltalirz ltalirz changed the title replace reentry by importlib.meta replace reentry by importlib.metadata May 21, 2021
Co-authored-by: Tiziano Müller <tm@dev-zero.ch>
@ltalirz
Copy link
Member Author

ltalirz commented Jun 4, 2021

thanks!

@chrisjsewell
Copy link
Member

chrisjsewell commented Jun 16, 2021

Hey @ltalirz, just to note, as of python 3.10 (https://docs.python.org/3.10/library/importlib.metadata.html#entry-points) and already implemented in the importlib_metadata port (https://importlib-metadata.readthedocs.io/en/latest/using.html#entry-points), they are moving away from the dictionary interface for retrieving entry points, to use the more explicit select method (which maybe, hopefully, should be even fsater?).

As an example, I have implemented this in another of my packages: executablebooks/MyST-NB@a4c21b1

@ltalirz
Copy link
Member Author

ltalirz commented Aug 12, 2021

superseded by #5058

@ltalirz ltalirz closed this Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants