Also export empty repository folders (for zip) #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasperWA
force-pushed
the
fix_3321_export_empty_repo_folders
branch
from
afa876f to
a8f3d91
Compare
CasperWA
changed the title
d-tomerini
previously approved these changes
Sep 17, 2019
CasperWA
force-pushed
the
fix_3321_export_empty_repo_folders
branch
from
a8f3d91 to
0324f8b
Compare
|
@d-tomerini I have now updated the test, made sure it passes (when rebased on the branch for PR #3242), and all should be good-to-go :) I.e., feel free to re-approve 😅 |
d-tomerini
approved these changes
Sep 18, 2019
d-tomerini
pushed a commit
to d-tomerini/aiida_core
that referenced
this pull request
Sep 30, 2019
d-tomerini
pushed a commit
to d-tomerini/aiida_core
that referenced
this pull request
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3321
Blocked by PR #3242, since this fixes the issue of the
extract_treefunction, which the new test makes use of.Edit: The actual fix is not blocked, only the test. I have skipped the new test until PR #3242 has been merged/issue #3199 has been fixed.
It should now be good-to-go.