Implement the new base ORM classes for process nodes #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_2167_define_process_node_base_hierarchy
branch
from
730c4c9 to
ff7bb46
Compare
giovannipizzi
previously approved these changes
Nov 11, 2018
|
Let's not merge this yet. I'm still working a bit on the structure. Ideally, we can expose every submodule to its parent, such that eventually, one can do |
sphuber
changed the title
sphuber
force-pushed
the
fix_2167_define_process_node_base_hierarchy
branch
4 times, most recently
from
1a5c009 to
91f9646
Compare
This commit defines the new basic hierarcy of the ORM classes for process nodes. In addition, it already moves over the functionality of the current abstract calculation classes to their new corresponding counterpart. - `AbstractCalculation` -> `ProcessNode` and `CalcJobNode` - `AbstractJobCalculation` -> `CalcJobNode` This should allow the refactoring of the code according to the renaming of the node ORM classes to begin.
sphuber
force-pushed
the
fix_2167_define_process_node_base_hierarchy
branch
from
91f9646 to
96d9d7b
Compare
sphuber
changed the title
|
OK, the tests now pass and I tested the setup by starting migration of |
giovannipizzi
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2167
This commit defines the new basic hierarcy of the ORM classes for process nodes.
In addition, it already moves over the functionality of the current abstract
calculation classes to their new corresponding counterpart.
AbstractCalculation->ProcessNodeandCalcJobNodeAbstractJobCalculation->CalcJobNodeThis should allow the refactoring of the code according to the renaming of the
node ORM classes to begin.