Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in restapi if custom schema is not defined for node #1485

Closed
wants to merge 5 commits into from

Conversation

waychal
Copy link
Contributor

@waychal waychal commented May 7, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented May 7, 2018

Codecov Report

Merging #1485 into develop will increase coverage by <.01%.
The diff coverage is 65.62%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1485      +/-   ##
===========================================
+ Coverage    56.75%   56.75%   +<.01%     
===========================================
  Files          277      277              
  Lines        34058    34082      +24     
===========================================
+ Hits         19329    19343      +14     
- Misses       14729    14739      +10
Impacted Files Coverage Δ
aiida/restapi/translator/node.py 46.89% <37.5%> (-0.33%) ⬇️
aiida/restapi/translator/user.py 80.95% <75%> (-5.72%) ⬇️
aiida/restapi/translator/group.py 80.95% <75%> (-5.72%) ⬇️
aiida/restapi/translator/computer.py 85.71% <75%> (-7.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c3029...347c1d2. Read the comment docs.

@ltalirz
Copy link
Member

ltalirz commented May 7, 2018

@waychal Please recreate these fixes on top of release_v0.12.1 (it can take a very long time until develop will be released)

@ltalirz
Copy link
Member

ltalirz commented May 7, 2018

Closed in favor of #1490 , based on release_v0.12.1

@ltalirz ltalirz closed this May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants