-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 2.7 with next minor release #9
Drop support for Python 2.7 with next minor release #9
Conversation
Minor adjustments in language.
This AEP is to be interpreted as an alternative to this AEP. |
Hehe, should I now request changes on this? ;-) |
Co-Authored-By: Leopold Talirz <leopold.talirz@gmail.com>
Co-Authored-By: Leopold Talirz <leopold.talirz@gmail.com>
Co-Authored-By: Leopold Talirz <leopold.talirz@gmail.com>
I actually realized that it wouldn't be too much work to write the AEP for both alternatives and I found it a little easier to argue for this variant TBH. So I think we should have a quick discussion on which variant is generally preferred and then work out the details on that. |
818bccd
to
95b9789
Compare
For improved readability.
2fb15a7
to
9d21fc9
Compare
Just for my understanding of the protocol: what determines the number of the AEP? Why 300? When it will be finally approved, just before merging will it take the next available subsequent number, i.e. 001? Or are they not supposed to be sequential? |
I feel it should be consistent with https://www.python.org/dev/peps/pep-0001/#pep-editor-responsibilities-workflow. Though I think sequential would make most sense.
|
yes, that was the idea + the status will be changed to "active". If changed the branch protection rules such that further pushes to the branch don't dismiss an approval. |
So @csadorf did you chose 300 to keep 0-100 for meta and to indicate that this marks the start of python 3 only? (Since we probably won't be doing PEP's for py2 branches) |
I think we should keep the number until next Tuesday for discussion purposes and then we can reassign one if we feel strongly about it before merging. |
So far there have been no comments on the mailing list. Anything else that would need to be addressed prior to accepting this tomorrow? |
I guess just to decide the numbering, but other than that I think this is good to go. I already prepared a PR to actually drop the support and clean up all the code. Dominik already gave it a pass, but it would be good to have others give a look as well, as well as try and go through the code base itself to see if I missed something. Then I want to release |
@ltalirz Since you are championing this AEP, are you going to take charge of that? |
I don't think my approval counts here 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alle trossen los!
@ltalirz Should be ready for merge. |
Aaand we have our first AEP merged. Thanks a bunch @csadorf ! |
submitted
README.md