refactor(sherlock): convert to typescript #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveoh
changed the title
|
This is looking good to me. |
|
It might make sense to do the utilities in this pr since a lot is shared. |
Sorry I missed this. Hopefully the utilities changes will be able to be rebased into this PR without any issues. |
watch is unnecessary as it's fairly simple to add -- --watch to the end. it's almost the same amount of typing
steveoh
force-pushed
the
refactor/sherlock-ts
branch
from
f94fd5d to
3f2e95e
Compare
|
Visit the preview URL for this PR (updated for commit 08ba205): |
steveoh
force-pushed
the
refactor/sherlock-ts
branch
from
ca9dc1d to
a0a1228
Compare
steveoh
force-pushed
the
refactor/sherlock-ts
branch
from
a0a1228 to
e715682
Compare
stdavis
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤯
i can go either way on having more run scripts or passing the watch flag to an existing one 🤷🏼