Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Sherlock input value to be controlled #340

Closed
stdavis opened this issue Oct 30, 2024 · 3 comments
Closed

Allow Sherlock input value to be controlled #340

stdavis opened this issue Oct 30, 2024 · 3 comments
Assignees
Labels
design-system enhancement New feature or request

Comments

@stdavis
Copy link
Member

stdavis commented Oct 30, 2024

This would allow us to clear the input value from outside of the component. For example, I would like to clear the sherlock input when this clear button is clicked:
image

@stdavis stdavis added enhancement New feature or request design-system labels Oct 30, 2024
@steveoh
Copy link
Member

steveoh commented Oct 31, 2024

I have vague memories of us talking about this during development and there was something about nesting it in a form and maybe using a reset button?

@stdavis
Copy link
Member Author

stdavis commented Oct 31, 2024

Yes, I think that this would be a similar use case, no?

@stdavis
Copy link
Member Author

stdavis commented Nov 18, 2024

This was closed via the context param introduced in #368

@stdavis stdavis closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-system enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants