Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build and Drawer fixes #361

Merged
merged 9 commits into from
Nov 13, 2024
Merged

Remove build and Drawer fixes #361

merged 9 commits into from
Nov 13, 2024

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented Nov 12, 2024

The animation of the tray when it goes fullscreen is a little jakey still. I could use some help with it if you can figure it out. Otherwise, I think that it's good enough.

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Visit the preview URL for this PR (updated for commit 51a3988):
Firebase Preview: https://ut-dts-agrc-kitchen-sink-dev--scott-fixes-9cf915lz.web.app
(expires "2024-11-27T00:39:04.149621414Z" )

@stdavis
Copy link
Member Author

stdavis commented Nov 12, 2024

Here's an example of the changes that would need to be made to existing apps to make the new drawer trigger line up properly: agrc/atlas#486

Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the animation is good enough.

@stdavis stdavis merged commit ca826f1 into main Nov 13, 2024
6 checks passed
@stdavis stdavis deleted the scott-fixes branch November 13, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants