Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer (type=sidebar) Toggle Button Alignment #345

Closed
stdavis opened this issue Nov 1, 2024 · 4 comments
Closed

Drawer (type=sidebar) Toggle Button Alignment #345

stdavis opened this issue Nov 1, 2024 · 4 comments
Assignees
Labels
bug Something isn't working design-system

Comments

@stdavis
Copy link
Member

stdavis commented Nov 1, 2024

When I fixed the gap between the sidebar and the main container in electrofishing, to be consistent with the other gaps, it made the toggle button offset in the wrong place:
image

@stdavis stdavis added bug Something isn't working design-system labels Nov 1, 2024
@stdavis
Copy link
Member Author

stdavis commented Nov 5, 2024

Now the tray version is messed up as well:
image

The layout is off and clicking on it does not toggle the drawer. I tried testing this out in storybook but the stories for this component are broken.

@steveoh
Copy link
Member

steveoh commented Nov 5, 2024

Yeah our drawer/tray implementation was very dependent on the layout. Do you have any suggestions for correcting it?

@stdavis
Copy link
Member Author

stdavis commented Nov 5, 2024

It looks like it's a problem in Atlas as well:
image

The only thing that is different between this project and atlas is that I fixed the gap to the left of the map so that it matched everything else. I'm happy to make the same fix to atlas. Or maybe you think that it should stay?

The issues with the tray seem to be unrelated to the app layout to me.

@stdavis stdavis self-assigned this Nov 7, 2024
@steveoh
Copy link
Member

steveoh commented Nov 13, 2024

this was closed by #361

@steveoh steveoh closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design-system
Projects
None yet
Development

No branches or pull requests

2 participants