Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkbox component #60

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Conversation

booi-dev
Copy link

@booi-dev booi-dev commented Feb 6, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

cloudflare-workers-and-pages bot commented Feb 12, 2025

Deploying unicorn-design-system with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3a81b8e
Status:🚫  Build failed.

View logs

@booi-dev booi-dev changed the title []Update checkbox component Update checkbox component Feb 12, 2025
package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@aftershootco/pegasus",
"version": "1.0.50",
"version": "1.0.55",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump just one version please

package.json Outdated
@@ -69,7 +68,7 @@
"rollup-plugin-terser": "^7.0.2",
"sass": "^1.58.0",
"sass-loader": "^13.2.0",
"style-loader": "^3.3.1",
"style-loader": "^4.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the update? any particular reason?

@@ -80,7 +79,8 @@
],
"types": "dist/index.d.ts",
"dependencies": {
"clsx": "^1.2.1"
"clsx": "^1.2.1",
"tailwind-merge": "^3.0.1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this being used?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cn function. /src/utils/cn.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants