AEROGEAR-1986 split up keycloak config into secret and non secret parts #26
Conversation
pb82
requested review from
david-martin,
philbrookes,
psturc,
darahayes,
aidenkeating and
StevenTobin
| name: keycloak | ||
| namespace: '{{ namespace }}' | ||
| labels: | ||
| name: keycloak |
There was a problem hiding this comment.
@philbrookes this seems redundant. Does the mobile-cli need the name to be in a label too?
There was a problem hiding this comment.
I think this can be removed.
| metadata: | ||
| name: keycloak | ||
| namespace: {{ namespace }} | ||
| labels: | ||
| name: keycloak | ||
| mobile: enabled | ||
| stringData: | ||
| serviceName: keycloak | ||
| data: | ||
| type: keycloak | ||
| realm: {{namespace}} | ||
| name: keycloak |
There was a problem hiding this comment.
@philbrookes this seems redundant. Does the mobile-cli need the name as a label and in metadata?
There was a problem hiding this comment.
There was a problem hiding this comment.
@pb82 oh my mistake, I see that it is listed in both metadata and labels now, the location of this comment threw me off!
Yes, I think just having one of these would be sufficient.
There was a problem hiding this comment.
Yes I think we can largely work from the service instances now so likely don't need the additional name
|
@maleck13 would appreciate your review of this based on the proposal |
|
@pb82 did |
|
@psturc Yes, it worked for me. Let's see what Jenkins says. |
|
Well it doesn't look good. Looks like the same issue as in https://issues.jboss.org/browse/AEROGEAR-1987 |
There was a problem hiding this comment.
This looks about what I would expect. However I think @philbrookes and @pb82 should sync up and test that we can get the config ok and that we can do a binding between sync and kc ok (particularly via the CLI) IF there are issues with this, we should update
https://issues.jboss.org/browse/AEROGEAR-1924 with the details
|
@maleck13 @philbrookes i tried this and updated https://issues.jboss.org/browse/AEROGEAR-1924 with the results. |
|
@maleck13 @dimitraz after adding the labels to the ServiceInstances of keycloak and fh-sync-server and running |
Split up the keycloak config into secret and non secret parts where the non-secret parts are stored in a config map.
Based on this proposal: https://github.com/aerogear/proposals/blob/master/apbs/create-secret-and-configmap-during-provision.md#proposed-solution
To verify, checkout this branch and provision the apb. After everything is deployed, check that both, a config map and a secret with the name
keycloakexist. The secret should only contain username and password. Delete the service instance. The config map and the secret should also be deleted.