Add go report card to readme #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbrookes
changed the title
philbrookes
force-pushed
the
add-coveralls-reporting
branch
5 times, most recently
from
27ccbdf to
ed4cc96
Compare
maleck13
approved these changes
Feb 12, 2018
There was a problem hiding this comment.
changes look ok to me but will let @AdamSaleh have final say
philbrookes
force-pushed
the
add-coveralls-reporting
branch
4 times, most recently
from
5621e9d to
4daf6c4
Compare
philbrookes
force-pushed
the
add-coveralls-reporting
branch
from
4daf6c4 to
7a9ed4d
Compare
|
@AdamSaleh any thoughts on this PR? |
philbrookes
changed the title
AdamSaleh
approved these changes
Feb 13, 2018
| @@ -38,11 +38,16 @@ podTemplate(label: 'mobile-cli-go', cloud: "openshift", containers: [goSlaveCont | |||
|
|
|||
| stage ("Setup") { | |||
| sh "glide install" | |||
| sh "go get golang.org/x/tools/cmd/cover" | |||
| sh "go get github.com/mattn/goveralls" | |||
There was a problem hiding this comment.
We probably should bake this into the slave image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Add coveralls.io report to PR
Changes proposed in this pull request