Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded label #55

Merged
merged 2 commits into from
Jan 31, 2018
Merged

remove unneeded label #55

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cab5dc
remove unneeded label
maleck13 Jan 30, 2018
f94ac8d
remove labels
maleck13 Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/cmd/services.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ Run the "mobile get services" command from this tool to see which services are a
Kind: "ServiceInstance",
},
ObjectMeta: metav1.ObjectMeta{
Labels: map[string]string{"id": sid, "serviceName": extServiceClass.ServiceName},
Labels: map[string]string{"id": sid},
Namespace: ns,
GenerateName: validServiceName + "-",
},
Expand Down Expand Up @@ -364,7 +364,7 @@ Run the "mobile get services" command from this tool to see which services are a
if noWait {
return nil
}
w, err := sc.scClient.ServicecatalogV1beta1().ServiceInstances(ns).Watch(metav1.ListOptions{LabelSelector: "id=" + sid})
w, err := sc.scClient.ServicecatalogV1beta1().ServiceInstances(ns).Watch(metav1.ListOptions{LabelSelector: "serviceName=" + validServiceName})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CLI still adds the id label, so i guess we don't have to change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep not used now so can probably be removed

if err != nil {
return errors.WithStack(err)
}
Expand Down