Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added appIdentifier to mobile crd added fields for validation #47

Merged
merged 2 commits into from
Jan 25, 2018
Merged

added appIdentifier to mobile crd added fields for validation #47

merged 2 commits into from
Jan 25, 2018

Conversation

maleck13
Copy link
Contributor

Describe what this PR does and why we need it:

Changes proposed in this pull request

  • add new field to the CRD appIdentifier
  • add required fields (wont take effect till k8s 1.9 but also have no drawback

@maleck13 maleck13 merged commit 94f6225 into aerogear-attic:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philbrookes philbrookes philbrookes approved these changes

@sedroche sedroche sedroche approved these changes

@dimitraz dimitraz Awaiting requested review from dimitraz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maleck13 @philbrookes @sedroche