[WIP] AEROGEAR-1881 Delete service instance via CLI #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyates86
changed the title
maleck13
approved these changes
Jan 22, 2018
| return &kFake.Clientset{} | ||
| }, | ||
| ExpectError: false, | ||
| ValidateErr: func(t *testing.T, err error) { |
There was a problem hiding this comment.
I see a defined ValidateOutput in the struct but not seeing it used here. Is there any none error output to validate?
dimitraz
reviewed
Jan 22, 2018
pkg/cmd/services.go
Outdated
| @@ -362,6 +363,12 @@ func (sc *ServicesCmd) DeleteServiceInstanceCmd() *cobra.Command { | |||
| return &cobra.Command{ | |||
| Use: "serviceinstance <serviceInstanceID>", | |||
| Short: "deletes a service instance and other objects created when provisioning the services instance such as pod presets", | |||
| Long: `Delete service instance, allows you to delete a service instance and other objects created when provisioning the services instance such as pod presets". | |||
There was a problem hiding this comment.
I would remove the comma after instance and the " after presets
sedroche
approved these changes
Jan 22, 2018
pyates86
force-pushed
the
AEROGEAR-1881-review-delete-service-via-cli
branch
from
bfc1b9d to
54bdafc
Compare
dimitraz
approved these changes
Jan 22, 2018
description to deleteServiceInstance and listServiceInstance methods
pyates86
force-pushed
the
AEROGEAR-1881-review-delete-service-via-cli
branch
from
7d7c97b to
dbdfc3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Added unit tests for delete service method, and added Long description to the method.
Changes proposed in this pull request
unit tests
updated description
Does this PR depend on another PR (Use this to track when PRs should be merged)
depends-on
no
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes Aerogear 1881