Proof of concept integration tests cli client commands

[AdamSaleh]

Describe what this PR does and why we need it:

As described in https://issues.jboss.org/browse/AEROGEAR-1860, we need to have integration tests.

Changes proposed in this pull request

• the https://raw.githubusercontent.com/aerogear/mobile-cli/master/artifacts/mobileclient_crd.yaml would be setup on our jenkins-wendy.ci, to allow to run this on PR.
• the tests themselves are in go, using exec.Command to perform simple cli integration tests
• for result verification we would be using -o json and json.Unmarshal
• tests are using flags, to allow for parametrization, currently supporting -namespace and -name, it might be better if name was randomly generated
• the tests should be reasonably stand-alone, allowing us to run them without setup

To discuss

• because we are testing eventually consistent system, we probably need to allow for certain ammount of leeway when executing the tests, and include some ammount of timeout-based retries. We should agree on this.

Does this PR depend on another PR (Use this to track when PRs should be merged)

• Might collide with @witmicko integration testing.

Which issue this PR fixes (This will close that issue when PR gets merged)
fixes AEROGEAR-1860

[maleck13]

package integration

[AdamSaleh]

You should be able to run the new tests in a $NAMESPACE

go test -run ClientJson -v ./integration/ -args -namespace=$NAMESPACE -prefix=test -executable=/home/asaleh/go/src/github.com/aerogear/mobile-cli/mobile

I think the old tests should still work fine, but I so far changed them to require explicit executable path.

go test -run GetServices -v ./integration/ -args -namespace=$NAMESPACE -prefix=test -executable=/home/asaleh/go/src/github.com/aerogear/mobile-cli/mobile

I think that could be done better.
I think I should create a cleanup-step as well.

[maleck13]

this can be shortened to if err := json.Unmarshal(); err != nil{ }

[maleck13]

I think what we want here is a custom error type

 type ClientJsonErr struct{
message string
clientType string
}
func (ce ClientJsonErr)Error()string{
   return ce.message
}
func (ce ClientJsonErr)ClientType()string{
  return ce.clientType
}

[vchepeli]

Exec string

[maleck13]

@AdamSaleh I am ok with this for now. I wouldn't call it idiomatic go, but there doesn't look to be anything particularly wrong with it. We may find we want to change and adjust things as time goes on and experience in Go grows, but for now it looks fine. I haven't verified it yet as I think @vchepeli was doing that.

[AdamSaleh]

Yay, if you are in oc project on your dev-setuped openshift, just running

make integration

now works :)

[witmicko]

any reason why release is removed?

[witmicko]

one comment, lgtm otherwise