fix matplotlib deprecation

adrinjalali · Jun 4, 2024 · 361f566 · 361f566
1 parent effd5ba
commit 361f566
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/skops/card/_model_card.py b/skops/card/_model_card.py
@@ -22,6 +22,7 @@
 from skops.card._templates import CONTENT_PLACEHOLDER, SKOPS_TEMPLATE, Templates
 from skops.io import load
 from skops.utils.importutils import import_or_raise
+from skops.utils._fixes import boxplot
 
 if sys.version_info >= (3, 11):
     from typing import Self
@@ -1225,9 +1226,9 @@ def add_permutation_importances(
             )
         sorted_importances_idx = permutation_importances.importances_mean.argsort()
         _, ax = plt.subplots()
-        ax.boxplot(
+        boxplot(ax,
             x=permutation_importances.importances[sorted_importances_idx].T,
-            labels=columns[sorted_importances_idx],
+            tick_labels=columns[sorted_importances_idx],
             vert=False,
         )
         ax.set_title(plot_name)

diff --git a/skops/utils/_fixes.py b/skops/utils/_fixes.py
@@ -0,0 +1,6 @@
+def boxplot(ax,*, tick_labels, **kwargs):
+    """A function to handle labels->tick_labels deprecation."""
+    try:
+        return ax.boxplot(tick_labels=tick_labels, **kwargs)
+    except TypeError:
+        return ax.boxplot(labels=tick_labels, **kwargs)