New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve input checking of composite_ppi() and fix ylim bug #389

Merged

adokter merged 1 commit into adokter:master from barthoekstra:composite_ppi_fix

May 18, 2020

Collaborator

barthoekstra commented May 17, 2020

There are a few integer/numeric inconsistencies in the input checking that I've fixed:

nx and ny (output cols and rows) have to be (positive) integers, so should be checked with is.count() instead of is.number().
xlim and ylim correspond with latlon limits, so do not have to be integers necessarily.

Additionally ylim could be defined, but was never used.


          Improve input checking and fix latitudes bug

Fix unused latitudes variable


Fix typos

adokter merged commit 42072e5 into adokter:master

barthoekstra deleted the composite_ppi_fix branch

May 18, 2020 16:12

adokter mentioned this pull request

hotfix for composite_ppi() #391

Merged

peterdesmet added this to the 0.6.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet