Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download_pvolfiles aborts instead of skips days without data #636

Closed
adokter opened this issue Oct 6, 2023 · 0 comments
Closed

download_pvolfiles aborts instead of skips days without data #636

adokter opened this issue Oct 6, 2023 · 0 comments
Assignees
@adokter
Milestone
0.7.3

Comments

@adokter
Copy link
Owner

adokter commented Oct 6, 2023

download_pvolfiles() aborts download whenever a day is encountered without data.

download_pvolfiles(date_min=as.POSIXct("2020-10-09 00:00:00"), date_max=as.POSIXct("2020-10-10 23:59:59"), radar="KHDX", directory="/tmp")

Change behavior to skipping those days (throwing only a warning).
@adokter adokter self-assigned this Oct 6, 2023
@adokter adokter added this to the 1.0.0 milestone Oct 6, 2023
@adokter adokter modified the milestones: 1.0.0, 0.8 Oct 17, 2023
adokter added a commit that referenced this issue Oct 19, 2023
@adokter
Merge pull request #637 from adokter/fix_download_pvolfiles
7121339 
skip day instead of abort when no data available (fix #636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adokter adokter

Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

No branches or pull requests
1 participant
@adokter